Skip to content

feat: card Storybook Components#811

Merged
asyncapi-bot merged 28 commits into
asyncapi:masterfrom
TenzDelek:card
Mar 4, 2026
Merged

feat: card Storybook Components#811
asyncapi-bot merged 28 commits into
asyncapi:masterfrom
TenzDelek:card

Conversation

@TenzDelek

Copy link
Copy Markdown
Member

Description
created storybook for cards

  1. Venue
Screenshot 2025-10-05 at 12 00 08 PM
  1. Speaker
Screenshot 2025-10-05 at 11 59 57 AM
  1. past-edition
Screenshot 2025-10-05 at 12 00 03 PM

Related issue(s)

GSOC

@netlify

netlify Bot commented Oct 5, 2025

Copy link
Copy Markdown

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d915306
🔍 Latest deploy log https://app.netlify.com/projects/peaceful-ramanujan-288045/deploys/69a84f244317e6000878641d
😎 Deploy Preview https://deploy-preview-811--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@AceTheCreator AceTheCreator left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think we might need to rethink this card Storybook setup. The current approach treats stories as one-to-one with use cases, but they should really map one-to-one with components.

I understand your reasoning, since we have three card implementations, that’s three separate components, each with its own story file. But that separation should be because they’re technically different components, not because of different use cases.

A better approach would be to create a single, flexible Card component with variants that cover all three cases. The goal of a design system is to capture patterns and build reusable solutions. If every use case becomes its own component, we lose that consistency and end up with a collection of one-offs.

Great work so far 💪🏽
Let me know what you think, @TenzDelek.

cc @ashmit-coder

@TenzDelek

TenzDelek commented Oct 18, 2025

Copy link
Copy Markdown
Member Author

think we might need to rethink this card Storybook setup. The current approach treats stories as one-to-one with use cases, but they should really map one-to-one with components.

I understand your reasoning, since we have three card implementations, that’s three separate components, each with its own story file. But that separation should be because they’re technically different components, not because of different use cases.

A better approach would be to create a single, flexible Card component with variants that cover all three cases. The goal of a design system is to capture patterns and build reusable solutions. If every use case becomes its own component, we lose that consistency and end up with a collection of one-offs.

Great work so far 💪🏽 Let me know what you think, @TenzDelek.

cc @ashmit-coder

Thank you Ace for your suggestion but I think forcing those card into one component would be the wrong kind of abstraction and would be much harder to maintain in the long run. there will be unnecessary to much of prop passing and conditional.
I think instead of that, we can go with similar case of how shadcn does. using a base card component (kind of a wrapper).
cc @AceTheCreator @ashmit-coder

@AceTheCreator

Copy link
Copy Markdown
Member

think we might need to rethink this card Storybook setup. The current approach treats stories as one-to-one with use cases, but they should really map one-to-one with components.
I understand your reasoning, since we have three card implementations, that’s three separate components, each with its own story file. But that separation should be because they’re technically different components, not because of different use cases.
A better approach would be to create a single, flexible Card component with variants that cover all three cases. The goal of a design system is to capture patterns and build reusable solutions. If every use case becomes its own component, we lose that consistency and end up with a collection of one-offs.
Great work so far 💪🏽 Let me know what you think, @TenzDelek.
cc @ashmit-coder

Thank you Ace for your suggestion but I think forcing those card into one component would be the wrong kind of abstraction and would be much harder to maintain in the long run. there will be unnecessary to much of prop passing and conditional. I think instead of that, we can go with similar case of how shadcn does. using a base card component (kind of a wrapper). cc @AceTheCreator @ashmit-coder

@TenzDelek can you share a link on how shadcn does it?

@TenzDelek

Copy link
Copy Markdown
Member Author

think we might need to rethink this card Storybook setup. The current approach treats stories as one-to-one with use cases, but they should really map one-to-one with components.
I understand your reasoning, since we have three card implementations, that’s three separate components, each with its own story file. But that separation should be because they’re technically different components, not because of different use cases.
A better approach would be to create a single, flexible Card component with variants that cover all three cases. The goal of a design system is to capture patterns and build reusable solutions. If every use case becomes its own component, we lose that consistency and end up with a collection of one-offs.
Great work so far 💪🏽 Let me know what you think, @TenzDelek.
cc @ashmit-coder

Thank you Ace for your suggestion but I think forcing those card into one component would be the wrong kind of abstraction and would be much harder to maintain in the long run. there will be unnecessary to much of prop passing and conditional. I think instead of that, we can go with similar case of how shadcn does. using a base card component (kind of a wrapper). cc @AceTheCreator @ashmit-coder

@TenzDelek can you share a link on how shadcn does it?

https://ui.shadcn.com/docs/components/card cc @AceTheCreator

@TenzDelek

Copy link
Copy Markdown
Member Author

hi @AceTheCreator ,@ashmit-coder , I went through the codebase of the main website. and it seems they are also keeping it in a distributive way. I think this would be much approachable and cleaner than what you suggested. because thinking in another way all three card seems to be way different in terms of ui. but happy to hear what your thought on this one as well. 😄
prev gsoc pr related with it asyncapi/website#3122

@AceTheCreator

Copy link
Copy Markdown
Member

hi @AceTheCreator ,@ashmit-coder , I went through the codebase of the main website. and it seems they are also keeping it in a distributive way. I think this would be much approachable and cleaner than what you suggested. because thinking in another way all three card seems to be way different in terms of ui. but happy to hear what your thought on this one as well. 😄 prev gsoc pr related with it asyncapi/website#3122

Okay, let's do it that way then 👍🏾

@TenzDelek

Copy link
Copy Markdown
Member Author

hi @AceTheCreator ,@ashmit-coder , I went through the codebase of the main website. and it seems they are also keeping it in a distributive way. I think this would be much approachable and cleaner than what you suggested. because thinking in another way all three card seems to be way different in terms of ui. but happy to hear what your thought on this one as well. 😄 prev gsoc pr related with it asyncapi/website#3122

Okay, let's do it that way then 👍🏾

this pr is already doing that. happy for a quick review.

@AceTheCreator AceTheCreator left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TenzDelek, are you planning on implementing the ticket card component?

Comment thread components/Cards/VenueCard/VenueCard.stories.tsx
Comment thread components/Speaker/speaker.stories.tsx Outdated
@TenzDelek
TenzDelek marked this pull request as draft December 21, 2025 13:22
@TenzDelek

Copy link
Copy Markdown
Member Author

what we did additionally:

  1. group all 4 card in /card directory and improve some naming of the component
  2. create a UI separate card component for ticket.

@TenzDelek
TenzDelek marked this pull request as ready for review January 12, 2026 06:40
@TenzDelek

Copy link
Copy Markdown
Member Author

ready for review @AceTheCreator

Comment thread pages/venue/[id].tsx Outdated
AceTheCreator and others added 4 commits January 23, 2026 23:45
Rename Guidelines.tsx to guidelines.tsx to fix case-sensitivity issue
in Linux build environments (Netlify). macOS is case-insensitive so the
issue wasn't caught locally, but the build was failing on CI.

@AceTheCreator AceTheCreator left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@AceTheCreator

Copy link
Copy Markdown
Member

Hey @TenzDelek good job on this 💜

@AceTheCreator

Copy link
Copy Markdown
Member

/rtm

@TenzDelek

Copy link
Copy Markdown
Member Author

merging as already approved by @AceTheCreator . the /rtm was unable to merge it due to unresolved comment

@TenzDelek

Copy link
Copy Markdown
Member Author

/rtm

@asyncapi-bot
asyncapi-bot merged commit 2211438 into asyncapi:master Mar 4, 2026
14 checks passed
@TenzDelek

Copy link
Copy Markdown
Member Author

thank you for the review Ace. learn a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants