Skip to content

feat: ros2 bindings #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Pakisan wants to merge 7 commits into
base: release/3.1.0
Choose a base branch
from
Open

feat: ros2 bindings #589

Pakisan wants to merge 7 commits into from

Conversation

@Pakisan
Copy link
Member

@Pakisan Pakisan commented Aug 9, 2025

Move ROS 2 bindings to 3.1.0

@Pakisan Pakisan changed the base branch from master to release/3.1.0 August 9, 2025 08:54
@Pakisan Pakisan mentioned this pull request Aug 9, 2025
Open
@derberg
Copy link
Member

derberg commented Aug 9, 2025

don't you want to add https://github.com/asyncapi/spec-json-schemas/pull/587/files#diff-c2284f868f0d14a73e8d4f312a685f775180238ee0d26966ad07ff8d0f879ce6 ?

@Pakisan
Merge branch 'release/3.1.0' into feat/ros2-bindings
5a35576 
# Conflicts:
#	bindings/ros2/0.1.0/operation.json
#	bindings/ros2/0.1.0/server.json
@Pakisan
Copy link
Member Author

Pakisan commented Aug 9, 2025

don't you want to add https://github.com/asyncapi/spec-json-schemas/pull/587/files#diff-c2284f868f0d14a73e8d4f312a685f775180238ee0d26966ad07ff8d0f879ce6 ?

Those changes are already here

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 12, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@amparo-siemens
Copy link
Contributor

amparo-siemens commented Dec 4, 2025

@Pakisan please add @gramss and I to the codeowners like in the asyncapi/bindings@d64de7a

@derberg derberg moved this to In Progress in Spec Triage Dec 18, 2025
@derberg derberg mentioned this pull request Dec 18, 2025
Closed
@amparosancho
Copy link

amparosancho commented Dec 19, 2025

@Pakisan please add @gramss and I to the codeowners like in the asyncapi/bindings@d64de7a

Could you put this account instead of the @amparo-siemens as @fmvilas suggested? Thanks

@Pakisan
Update CODEOWNERS
e4291a9 
Add ROS2 bindings code owners
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 19, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Pakisan
Copy link
Member Author

Pakisan commented Dec 19, 2025

@Pakisan please add @gramss and I to the codeowners like in the asyncapi/bindings@d64de7a

Could you put this account instead of the @amparo-siemens as @fmvilas suggested? Thanks

Hey, done

/bindings/ros2/         @gramss @amparosancho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@dalelane dalelane Awaiting requested review from dalelane dalelane is a code owner

@char0n char0n Awaiting requested review from char0n char0n is a code owner

@GreenRover GreenRover Awaiting requested review from GreenRover GreenRover is a code owner

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Spec Triage
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Pakisan @derberg @amparo-siemens @amparosancho