fix: prevent header wrapping on medium screens#5536
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR fixes header layout wrapping on medium screen sizes by adjusting responsive breakpoints from ChangesNavigation Menu Responsive Fix
🎯 2 (Simple) | ⏱️ ~12 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5536 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 931 931
Branches 180 180
=========================================
Hits 931 931 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5536--asyncapi-website.netlify.app/ |



Description
This PR fixes the header layout issue on medium screen widths where navigation items and the GitHub button wrap between
1024pxand1100px.The desktop navigation requires more horizontal space than
1024pxprovides, so this PR keeps the compact header visible until1100pxand only shows the full desktop navigation from1100pxupward.It also renders the mobile navigation menu through a React portal into
document.body. This prevents the fixed mobile menu from being constrained by the sticky/transformed navbar container at medium widths.Related Issue
Closes #4898
Changes
1100px.1100px+.MobileNavMenuvisibility to match the new1100pxbreakpoint.createPortalforMobileNavMenuso the overlay can use the full viewport height.Screenshots / Testing
Video demo of issue:
header-issue.webm
Video demo of fix:
header-fix.webm
Expected behavior:
1024pxand1100px.1100px+.Checklist
1024pxand1099px.Summary by CodeRabbit
Release Notes