fix(zitadel): don't prefix domain with https:// if another protocol is used#475
Merged
Merged
Conversation
atinux
approved these changes
Dec 2, 2025
commit: |
Contributor
Author
|
Hi @atinux, there was a TS issue indicated by the type-checking pipeline. Just fixed it. |
atinux
reviewed
Dec 2, 2025
atinux
reviewed
Dec 2, 2025
atinux
approved these changes
Dec 9, 2025
|
@ysemennikov Thanks so much for fixing this! (I just ran into this issue and saw that you fixed it, and I'm so happy I don't have to do it now :D ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it's impossible to use non-https base URL in the Zitadel connector, since the connector always prefixes the domain with
https://.This is very inconvenient when testing the setup locally, since locally we usually don't use https.
The PR fixes the issue.