Skip to content

fix: Added default Kubernetes parameters to VolumeClaimTemplate to prevent infinite DRIFT #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bianchi2 merged 5 commits into from
Nov 3, 2025
Merged

fix: Added default Kubernetes parameters to VolumeClaimTemplate to prevent infinite DRIFT #1030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c418532
fix: Added default Kubernetes parameters to VolumeClaimTemplate to pr…
HujinoKun Aug 10, 2025
b2149ae
Merge branch 'main' into fix/infinite-loop-with-volumeclaimtemplate-o…
HujinoKun Aug 12, 2025
db25346
Merge branch 'main' into fix/infinite-loop-with-volumeclaimtemplate-o…
bianchi2 Oct 30, 2025
77c7cb6
Fix tests
bianchi2 Nov 3, 2025
84ca12f
Merge branch 'main' into fix/infinite-loop-with-volumeclaimtemplate-o…
bianchi2 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/charts/bamboo/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,9 @@ persistentVolumeClaimRetentionPolicy:
{{- end}}
volumeClaimTemplates:
{{- if .Values.volumes.localHome.persistentVolumeClaim.create }}
- metadata:
- apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: local-home
spec:
accessModes: [ "ReadWriteOnce" ]
Expand Down
4 changes: 3 additions & 1 deletion src/main/charts/bitbucket/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,9 @@ persistentVolumeClaimRetentionPolicy:
{{- end}}
volumeClaimTemplates:
{{- if .Values.volumes.localHome.persistentVolumeClaim.create }}
- metadata:
- apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: local-home
spec:
accessModes: [ "ReadWriteOnce" ]
Expand Down
8 changes: 6 additions & 2 deletions src/main/charts/confluence/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,9 @@ persistentVolumeClaimRetentionPolicy:
{{- end}}
volumeClaimTemplates:
{{- if .Values.volumes.localHome.persistentVolumeClaim.create }}
- metadata:
- apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: local-home
spec:
accessModes: [ "ReadWriteOnce" ]
Expand Down Expand Up @@ -605,7 +607,9 @@ persistentVolumeClaimRetentionPolicy:
whenScaled: {{.Values.volumes.synchronyHome.persistentVolumeClaimRetentionPolicy.whenScaled}}
{{- end}}
volumeClaimTemplates:
- metadata:
- apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: synchrony-home
spec:
accessModes: [ "ReadWriteOnce" ]
Expand Down
4 changes: 3 additions & 1 deletion src/main/charts/crowd/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,9 @@ persistentVolumeClaimRetentionPolicy:
{{- end}}
volumeClaimTemplates:
{{- if .Values.volumes.localHome.persistentVolumeClaim.create }}
- metadata:
- apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: local-home
spec:
accessModes: [ "ReadWriteOnce" ]
Expand Down
4 changes: 3 additions & 1 deletion src/main/charts/jira/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,9 @@ persistentVolumeClaimRetentionPolicy:
{{- end}}
volumeClaimTemplates:
{{- if .Values.volumes.localHome.persistentVolumeClaim.create }}
- metadata:
- apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: local-home
spec:
accessModes: [ "ReadWriteOnce" ]
Expand Down
2 changes: 1 addition & 1 deletion src/test/resources/expected_helm_output/bamboo-agent/output.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ spec:
template:
metadata:
annotations:
checksum/config-jvm: 9a98b41a1da066f40ae9f4aa3287ac9be4e429b95c274256f832460a9d8712a3
checksum/config-jvm: e6302b5d728be9cb0332d747ef6e6d9ef2b7dc400065102fdb4d9759e6b58b57
labels:
app.kubernetes.io/name: bamboo-agent
app.kubernetes.io/instance: unittest-bamboo-agent
Expand Down
2 changes: 1 addition & 1 deletion src/test/resources/expected_helm_output/bamboo/output.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ spec:
template:
metadata:
annotations:
checksum/config-jvm: b705db3ed9b91938a23d626ca0f8725fb47af5bce6eb9848f586a5d4239d1a21
checksum/config-jvm: d39ffe576460a5be8eaa579df4e744d7fca12e30af7579f63412fcf3bd4f4dd8
labels:
helm.sh/chart: bamboo-2.0.5
app.kubernetes.io/name: bamboo
Expand Down
4 changes: 2 additions & 2 deletions src/test/resources/expected_helm_output/bitbucket/output.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,7 @@ spec:
template:
metadata:
annotations:
checksum/config-jvm: 71d151ebb77271e9b0c87e6631fe898e564007ab8af1144f123f9d2451e36a37
checksum/config-jvm: cb9e5fb87fcd54e34c0f4e3b8c6d172bc0613964ef4289bdb3ebfdffe3510931
labels:
app.kubernetes.io/name: bitbucket-mesh
app.kubernetes.io/instance: unittest-bitbucket
Expand Down Expand Up @@ -724,7 +724,7 @@ spec:
template:
metadata:
annotations:
checksum/config-jvm: f1af62bc806ba61471ce90cb05884979038428faa1576feb4fabc574325d4558
checksum/config-jvm: 6526e9d5f767c7c61f1c789fc0582d8e3e46c6d8858e781dc5be5030c0159fdf
labels:
helm.sh/chart: bitbucket-2.0.5
app.kubernetes.io/name: bitbucket
Expand Down
2 changes: 1 addition & 1 deletion src/test/resources/expected_helm_output/confluence/output.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ spec:
template:
metadata:
annotations:
checksum/config-jvm: 139f1cdd4101022a790de67975f105114f4fcc91b3039e5398592805123683d6
checksum/config-jvm: 04ff0c84ab05c7df598092cab4e3ed532c63c7ebdd6d6fa282db5cd050b64b49
labels:
helm.sh/chart: confluence-2.0.5
app.kubernetes.io/name: confluence
Expand Down
2 changes: 1 addition & 1 deletion src/test/resources/expected_helm_output/crowd/output.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ spec:
template:
metadata:
annotations:
checksum/config-jvm: 33b34c7dd5ed27e06a9c221da42805aeee39f7d9273f328833e104889586d433
checksum/config-jvm: 497118b00b16287b7740f0f2bea19d09ff7aac932a47557021c98924575aef7e
labels:
helm.sh/chart: crowd-2.0.5
app.kubernetes.io/name: crowd
Expand Down
2 changes: 1 addition & 1 deletion src/test/resources/expected_helm_output/jira/output.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ spec:
template:
metadata:
annotations:
checksum/config-jvm: 90dd7238442df6e5cd750fa929a1675353a9cf2d428dc0d782fc47b5c88b0128
checksum/config-jvm: 61db5d5c09601f3ab3a4a0800172be644e3ba0de0d23a6aa933bb7b743a48e39
labels:
helm.sh/chart: jira-2.0.5
app.kubernetes.io/name: jira
Expand Down
Loading