Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Implement completion additionalTextEdits #284

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/adapters/autocomplete-adapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,8 @@ export default class AutocompleteAdapter {
onDidConvertCompletionItem(item, suggestion as ac.AnySuggestion, request);
}

suggestion.completionItem = item;

return suggestion;
}

Expand Down
15 changes: 14 additions & 1 deletion lib/auto-languageclient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,10 @@ export default class AutoLanguageClient {
suggestionPriority: 2,
excludeLowerPriority: false,
getSuggestions: this.getSuggestions.bind(this),
onDidInsertSuggestion: this.onDidInsertSuggestion.bind(this),
onDidInsertSuggestion: (event) => {
this.handleAdditionalTextEdits(event);
this.onDidInsertSuggestion(event);
},
getSuggestionDetailsOnSelect: this.getSuggestionDetailsOnSelect.bind(this),
};
}
Expand Down Expand Up @@ -510,6 +513,16 @@ export default class AutoLanguageClient {
): void {
}

// Handle additional stuff after a suggestion insert, e.g. `additionalTextEdits`.
private handleAdditionalTextEdits(e: ac.SuggestionInsertedEvent): void {
const suggestion = e.suggestion as atomIde.SuggestionBase;
const additionalEdits = suggestion.completionItem && suggestion.completionItem.additionalTextEdits;
const buffer = e.editor.getBuffer();

ApplyEditAdapter.applyEdits(buffer, Convert.convertLsTextEdits(additionalEdits));
buffer.groupLastChanges();
}

protected onDidInsertSuggestion(_arg: ac.SuggestionInsertedEvent): void { }

// Definitions via LS documentHighlight and gotoDefinition------------
Expand Down
2 changes: 1 addition & 1 deletion lib/convert.ts
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ export default class Convert {
* @param textEdits The language server protocol {TextEdit} objects to convert.
* @returns An {Array} of Atom {TextEdit} objects.
*/
public static convertLsTextEdits(textEdits: ls.TextEdit[] | null): TextEdit[] {
public static convertLsTextEdits(textEdits?: ls.TextEdit[] | null): TextEdit[] {
return (textEdits || []).map(Convert.convertLsTextEdit);
}

Expand Down
4 changes: 4 additions & 0 deletions typings/atom-ide/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
declare module 'atom-ide' {
import { Disposable, Grammar, Point, Range, TextEditor } from 'atom';
import * as ac from 'atom/autocomplete-plus';
import { CompletionItem } from 'lib/languageclient';

export interface OutlineProvider {
name: string;
Expand Down Expand Up @@ -381,6 +382,9 @@ declare module 'atom-ide' {
* was gathered from.
*/
customReplacmentPrefix?: string;

/** Original completion item, if available */
completionItem?: CompletionItem;
}

export type TextSuggestion = SuggestionBase & ac.TextSuggestion;
Expand Down