Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Make element public #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make element public #34

wants to merge 1 commit into from

Conversation

ritzdorf
Copy link

Identify the Bug

With the current code the Readme example:

const SelectList = require('atom-select-list')

const usersSelectList = new SelectList({
  items: ['Alice', 'Bob', 'Carol']
})
document.body.appendChild(usersSelectList.element)

doesn't work, because element is private.

Description of the Change

Making element public.

Verification Process

No regression as no functionality removed.

Release Notes

  • The 'element' property is public allowing for its intended use.

Otherwise the example from the Readme:
```
const SelectList = require('atom-select-list')

const usersSelectList = new SelectList({
  items: ['Alice', 'Bob', 'Carol']
})
document.body.appendChild(usersSelectList.element)
```

doesn't work.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant