Recognise minimum prefix length

lib/autocomplete-snippets.js

@@ -1,10 +1,32 @@
+const {CompositeDisposable} = require('atom')
+
 module.exports = {
+  subscriptions: null,
   provider: null,
 
-  activate() {},
+  activate() {
+    this.subscriptions = new CompositeDisposable()
+    this.subscriptions.add(atom.config.observe('autocomplete-snippets.useAutocompletePlusMinimumWordLength', (value) => {
+      if (!this.provider) return
+      if (value) {
+        this.provider.minPrefixLength = atom.config.get('autocomplete-plus.minimumWordLength')
+      } else {
+        this.provider.minPrefixLength = atom.config.get('autocomplete-snippets.minimumWordLength')
+      }
+    }))
+    this.subscriptions.add(atom.config.observe('autocomplete-snippets.minimumWordLength', (value) => {
+      if (!this.provider || atom.config.get('autocomplete-snippets.useAutocompletePlusMinimumWordLength')) return
+      this.provider.minPrefixLength = value
+    }))
+    this.subscriptions.add(atom.config.observe('autocomplete-plus.minimumWordLength', (value) => {
+      if (!this.provider || !atom.config.get('autocomplete-snippets.useAutocompletePlusMinimumWordLength')) return
+      this.provider.minPrefixLength = value
+    }))
+  },
 
   deactivate() {
     this.provider = null
+    this.subscriptions.dispose()
   },
 
   provide() {

lib/snippets-provider.js

@@ -5,6 +5,9 @@ class SnippetsProvider {
     this.inclusionPriority = 1
     this.suggestionPriority = 2
     this.filterSuggestions = true
+    this.minPrefixLength = atom.config.get('autocomplete-snippets.useAutocompletePlusMinimumWordLength') ?
+      atom.config.get('autocomplete-plus.minimumWordLength') :
+      atom.config.get('autocomplete-snippets.minimumWordLength')
 
     this.showIcon = ['Symbol', 'Subsequence'].includes(atom.config.get('autocomplete-plus.defaultProvider'))
     this.snippetsSource = {
@@ -21,7 +24,7 @@ class SnippetsProvider {
   }
 
   getSuggestions({scopeDescriptor, prefix}) {
-    if (!(prefix != null ? prefix.length : undefined)) { return }
+    if (prefix == null || prefix.length < this.minPrefixLength) { return }
     const scopeSnippets = this.snippetsSource.snippetsForScopes(scopeDescriptor)
     return this.findSuggestionsForPrefix(scopeSnippets, prefix)
   }

package.json

@@ -25,5 +25,19 @@
         "0.1.0": "consumeSnippets"
       }
     }
+  },
+  "configSchema": {
+    "useAutocompletePlusMinimumWordLength": {
+      "description": "When enabled, the minimum prefix length will be that set for autocomplete-plus",
+      "type": "boolean",
+      "default": true,
+      "order": 1
+    },
+    "minimumWordLength": {
+      "description": "Minimum prefix length when not using the one set for autocomplete-plus",
+      "type": "integer",
+      "default": 3,
+      "order": 2
+    }
   }
 }

spec/autocomplete-snippets-spec.js

@@ -2,6 +2,9 @@ describe('AutocompleteSnippets', () => {
   let [completionDelay, editor, editorView] = []
 
   beforeEach(() => {
+    atom.config.set('autocomplete-snippets.minimumWordLength', 1)
+    atom.config.set('autocomplete-snippets.useAutocompletePlusMinimumWordLength', false)
+
     atom.config.set('autocomplete-plus.enableAutoActivation', true)
     completionDelay = 100
     atom.config.set('autocomplete-plus.autoActivationDelay', completionDelay)
@@ -49,6 +52,7 @@ describe('AutocompleteSnippets', () => {
         advanceClock(completionDelay)
       })
 
+
       waitsFor('autocomplete view to appear', 1000, () => editorView.querySelector('.autocomplete-plus span.word'))
 
       runs(() => {
@@ -75,6 +79,31 @@ describe('AutocompleteSnippets', () => {
         expect(editor.getText()).toContain('} while (true)')
       })
     })
+
+    describe('when picking minimum prefix length', () => {
+      it('respects the value set for autocomplete-plus', () => {
+        atom.config.set('autocomplete-snippets.useAutocompletePlusMinimumWordLength', true)
+
+        const plus = atom.config.get('autocomplete-plus.minimumWordLength')
+
+        const SnippetsProvider = require('../lib/snippets-provider')
+        const usedVal = (new SnippetsProvider()).minPrefixLength
+
+        expect(usedVal).toEqual(plus)
+      })
+
+      it('can be overridden by its own setting', () => {
+        atom.config.set('autocomplete-snippets.useAutocompletePlusMinimumWordLength', false)
+        const plus = atom.config.get('autocomplete-plus.minimumWordLength')
+        atom.config.set('autocomplete-snippets.minimumWordLength', plus + 1)
+        const snippet = atom.config.get('autocomplete-snippets.minimumWordLength')
+
+        const SnippetsProvider = require('../lib/snippets-provider')
+        const usedVal = (new SnippetsProvider()).minPrefixLength
+
+        expect(usedVal).toEqual(snippet)
+      })
+    })
   })
 
   describe('when showing suggestions', () =>
@@ -94,6 +123,7 @@ describe('AutocompleteSnippets', () => {
 
       const SnippetsProvider = require('../lib/snippets-provider')
       const sp = new SnippetsProvider()
+      sp.minPrefixLength = 1
       sp.setSnippetsSource({snippetsForScopes(scope) {
         return snippets
       }})