Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Fix item score bias affecting commands with extra metadata #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib/command-palette-view.js
Original file line number Diff line number Diff line change
Expand Up @@ -178,18 +178,22 @@ export default class CommandPaletteView {

const scoredItems = []
for (const item of items) {
let score = this.fuzz.score(item.displayName, query)
const displayNameScore = this.fuzz.score(item.displayName, query)
let tagScore;
let descriptionScore;

if (item.tags) {
score += item.tags.reduce(
tagScore = item.tags.reduce(
(currentScore, tag) => currentScore + this.fuzz.score(tag, query),
0
)
}
if (item.description) {
score += this.fuzz.score(item.description, query)
descriptionScore = this.fuzz.score(item.description, query)
}

if (score > 0) {
if (displayNameScore > 0 || tagScore > 0 || descriptionScore > 0) {
const score = Math.max(displayNameScore, tagScore, descriptionScore)
scoredItems.push({item, score})
}
}
Expand Down