JavaScript is broken

[ghost]

Hi. JavaScript the syntax highlighting is broken and this is affecting me in both Atom and GitHub code viewer. Please see the attached images.

github-linguist/linguist#2530

[ghost]

linguist/issues/2530

[winstliu]

Looks like another case where strings aren't given enough priority.

[ghost]

Fortunately, const now works properly when using the destructuring syntax. This was failing a few weeks ago, but I was too lazy to report it.

const { a, b } = f()

Having said this, const is still broken in the following case:

export function* find (path, hook = _ => _) {
  const root = join(process.cwd(), path)
  return hook((yield fs.stat(path))
    .isDirectory() ? yield resolve(root) : root)
  function* resolve (root) {
    for (const file of function* () {
      for (const ext of Object.keys(jsVariants))
        for (const name of ["Flyfile", "flyfile"])
          yield join(root, `${name}${ext}`)
    }()) try { if (yield fs.stat(file)) return file } catch (_) {}
    throw { code: "ENOENT" }
  }
}

[winstliu]

Yeah, that's been fixed - Linguist just needs to update to a commit that has it.

[winstliu]

Interestingly, putting the bracket on a newline breaks highlighting in a different way...

[ghost]

😭

[ghost]

Another one that has been broken for a while (at least in Atom), which I also forgot to report is when using default parameters:

export function filter (pkg, load, blacklist = [], bind = "babel/register") {

[winstliu]

Yeah, I'm looking at the function-params regex, and it's pretty basic.