Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Apostrophe in comment reduces indentation level on auto-indent #560

Open
wbt opened this issue Feb 20, 2018 · 0 comments
Open

Apostrophe in comment reduces indentation level on auto-indent #560

wbt opened this issue Feb 20, 2018 · 0 comments

Comments

@wbt
Copy link

wbt commented Feb 20, 2018

Edit by @rsese

Smaller repro case from atom/atom#16990

var removeNode = function(){
if (1 == 1){ //'
if (1 == 1){
var example = 5
}
}
};

Both of the following were auto-indented by Atom (with four spaces per indent for visual clarity).
This code looks properly indented:

function example(param1) { //you wouldnt expect this apostrophe to affect indentation!
    var starter = doSomeFormatting(param1,
        {message: "hardcoded",
        information: extra,
        more: beyond}
    );
    var a = 4;
    var b = 5;
    return add(a,b);
}

This code does not:

function example(param1) { //you wouldn't expect this apostrophe to affect indentation!
var a = 4;
var b = 5;
var starter = doSomeFormatting(param1,
    {message: "hardcoded",
    information: extra,
    more: beyond}
    //The negative indentation error suggest that additional code here is no longer
    //a sub-block within the function example().
    //If there are multiple such comments, the indentation errors accumulate quickly.
);

and the only difference between them is a commented-out apostrophe, on a line after an open brace!

I noticed the same issue in Solidity and the issue may generalize beyond this package, but my last attempts at opening auto-indent issues on Atom got moved to language-specific packages (so I'm starting out there with these reports).

Versions

Atom: 1.23.2
Electron: 1.6.15
Chrome: 56.0.2924.87
Node: 7.4.0
language-ethereum: 0.3.9
language-javascript: 0.127.6
OS : Windows 10

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants