Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Add support for properties and relax support.function regex #210

Closed
wants to merge 13 commits into from

Conversation

winstliu
Copy link
Contributor

🚨 ⚠️ Do not merge yet! Specs on atom/atom also need to be updated! ⚠️ 🚨

This PR brings back #158 and combines it with #146.

  • support.function.dom.js has been kept and is prioritized over the now-generalized support.function.js regex.
  • entity.name.property.js now catches anything that doesn't fall into support.constant{.dom}.js and support.class.js

Before:
before

After:
after

/cc @bucaran since I know you had some concerns about this
/cc @nevir because this only adds .property for things not already marked as .class and .constant
/cc @Victorystick, @AMalininHere, @pchaigno

Refs #137
Fixes #37
Closes #146

Sorry for all the commits

@jerone
Copy link

jerone commented Aug 27, 2015

Will this detect functions executed with .call and .apply as functions? e.g.:

Array.prototype.shift.call(arguments);

@winstliu
Copy link
Contributor Author

@jerone
call

@winstliu
Copy link
Contributor Author

Going to close and re-open as a different PR to try to slim down the commits (and the fact that git is refusing to sync properly).

@winstliu winstliu closed this Aug 29, 2015
@winstliu winstliu deleted the wl-properties branch August 29, 2015 15:40
@winstliu winstliu restored the wl-properties branch August 29, 2015 15:47
@winstliu winstliu deleted the wl-properties branch August 29, 2015 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants