Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Add JSDoc support for optional parameter types #401

Merged
merged 4 commits into from
Aug 10, 2016

Conversation

bgriffith
Copy link
Contributor

This PR adds support for JSDoc highlighting of optional parameter types, defined by suffixing the type with = (http://usejsdoc.org/tags-type.html)

@param {type=} variable - description

After:

screen shot 2016-08-10 at 20 06 44

@winstliu
Copy link
Contributor

The = does not need to be escaped.

@bgriffith
Copy link
Contributor Author

@50Wliu Updated!

@winstliu
Copy link
Contributor

Upon looking at it again, =? should suffice, right? No need for a non-capturing group?

@bgriffith
Copy link
Contributor Author

Heh indeed! Trimmed it down.

@winstliu winstliu merged commit 8757a80 into atom:master Aug 10, 2016
@winstliu
Copy link
Contributor

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants