Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Extend list of DOM methods #404

Merged
merged 2 commits into from
Aug 16, 2016
Merged

Extend list of DOM methods #404

merged 2 commits into from
Aug 16, 2016

Conversation

Zirro
Copy link
Contributor

@Zirro Zirro commented Aug 15, 2016

This pull request extends the list of methods recognized as being part of the DOM. The original list was very incomplete and led to peculiar behaviour such as classList.add() and classList.remove() being coloured differently.

These additions were collected by iterating through several common DOM interfaces, mainly in Firefox and Chrome. For practical reasons it is by no means complete, but I believe it covers those which are most-used. Intentional omissions include prefixed properties and non-standard properties with little adoption. I also removed a couple of overlapping properties from the support.function.js regex.

@winstliu
Copy link
Contributor

For stuff like (exec|execScript), that won't work and will exit as soon as it reaches exec. So you have two options:

  1. (exec(script)?)
  2. (execScript|exec)

@Zirro
Copy link
Contributor Author

Zirro commented Aug 15, 2016

While I moved execCommand() in this PR, I don't think I changed the (exec|execScript)-logic. Furthermore, .exec(), .execScript() and .execCommand() all seem to highlight and receive the correct classes when I test in Atom.

@winstliu
Copy link
Contributor

Hmm, you're right - sorry about that. Just waiting for CI at this point.

@winstliu
Copy link
Contributor

Don't know what's up with Travis right now -.-

@winstliu winstliu merged commit 2ca6aba into atom:master Aug 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants