This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add support for watch options and windows recursive watch #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyjN7
force-pushed
the
Windows-recursive-watch-support
branch
from
a8be58d to
28f646c
Compare
|
Any news on this? |
|
@maxbrunsfeld Is there anything the community can do to help speed up (review of) this PR? This is a long-standing, painful issue for Windows users. |
|
/cc: @iolsen |
|
@smashwilson would this co-exist with the changes you're working on? If so, would you be willing to review? |
|
Hey @garyjN7 thanks for the contribution! We're quite far along in the project to improve and unify Atom's file watching functionality and API: https://github.com/atom/watcher Recursive watching on Windows is part of that. Rather that working to land this then undoing it when that lands, I'm going to just close this and ask you to be patient for atom/watcher to land. 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#101 These changes allow atom's tree-view package to recursively watch files and directories under a root folder on windows.