feat: ADR-004 (Nakamoto Bonus) #153
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
requested review from
giunatale,
tbruyelle,
jaekwon and
giuliostramondo
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| protoiface "google.golang.org/protobuf/runtime/protoiface" | ||
| protoimpl "google.golang.org/protobuf/runtime/protoimpl" | ||
| io "io" | ||
| reflect "reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import Note
giunatale
reviewed
Jul 8, 2025
| ifneq ($(GO_SYSTEM_VERSION), $(GO_REQUIRED_VERSION)) | ||
| @echo 'ERROR: Go version $(GO_REQUIRED_VERSION) is required for building AtomOne' | ||
| ifeq ($(shell echo "$(GO_SYSTEM_VERSION) $(GO_REQUIRED_VERSION)" | awk '{if ($$1 >= $$2) print "1"}'),) | ||
| @echo 'ERROR: Go version $(GO_REQUIRED_VERSION) or greater is required for building AtomOne (curent: $(GO_SYSTEM_VERSION))' |
There was a problem hiding this comment.
Please revert this. We use exact versions to achieve reproducible builds.
See https://github.com/atomone-hub/atomone?tab=readme-ov-file#reproducible-builds
|
closing to address my comment. PR for distribution module is #181, while PR for the Nakamoto bonus will come later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation of https://github.com/atomone-hub/atomone/blob/main/docs/architecture/adr-004-nakamoto-bonus.md
needs merge first: #141