test(e2e): dynamic quorum e2e tests #154
Conversation
giuliostramondo
requested review from
giunatale,
tbruyelle and
jaekwon
as code owners
|
Since #152 has been merged, can you rebase on main so we have a better diff ? |
giuliostramondo
force-pushed
the
giuliostramondo/test/dynamic-quorum-e2e
branch
from
23a262b to
d456ae5
Compare
| quorumMin := sdk.MustNewDecFromStr(quorumRange.Min) | ||
| quorumMax := sdk.MustNewDecFromStr(quorumRange.Max) | ||
| currentQuorum := sdk.MustNewDecFromStr(quorums.GetQuorum()) | ||
| quorumPEma := (currentQuorum.Sub(quorumMin)).Quo(quorumMax.Sub(quorumMin)) |
There was a problem hiding this comment.
Reading this code makes me realize that maybe the participationEMAs should be queryable. Maybe we could return the different participations in the Quorums query response ?
There was a problem hiding this comment.
I would use a separate, dedicated endpoint
| paramsFeemarket := s.queryFeemarketParams(chainAAPIEndpoint) | ||
| oldAlpha := paramsFeemarket.Params.Alpha | ||
| paramsFeemarket.Params.Alpha = oldAlpha.Add(sdk.NewDec(1)) | ||
| s.writeFeemarketParamChangeProposal(s.chainA, paramsFeemarket.Params) |
There was a problem hiding this comment.
I would rather use a less specific proposal for this test, it's confusing to imply the feemarket in it. We should use a simple text proposal, but there is currently no test for a text proposal submission, right ? Maybe it's time to add one.
There was a problem hiding this comment.
agreed, also this will make life easier for the renaming of the module, so we don't have leftover "feemarket" references
Description
E2E tests for the dynamic quorum feature
Closes: #145
(with PR #146)
Based on PR #152