fix(gov/simulation): return zero if max-min <= 0 for certain generated params #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giunatale
requested review from
tbruyelle,
jaekwon and
giuliostramondo
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failed run for PR #167 for the nondeterminism test (see https://github.com/atomone-hub/atomone/actions/runs/16119695430/job/45482097081?pr=167)
made me realize we need to avoid to have
n <= 0forIntn()(called byRandIntBetween) since this triggers a panic.This can happen if max ends up being == min (== 0) which may very well happen for certain generated genesis parameters in simulation that have parametric maximum.
Therefore, I added an if statement that returns a
sdk.ZeroDecvalue in case this happen, avoiding failure.