UPSTREAM PR #17524: server: enable jinja by default, update docs #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loci-dev
temporarily deployed
to
PROD__AL_DEMO
GitHub Actions
Inactive
loci-dev
force-pushed
the
main
branch
27 times, most recently
from
50d76f4 to
cbd9848
Compare
loci-dev
force-pushed
the
main
branch
30 times, most recently
from
5dbcd6b to
b63d258
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#17524
On server, we want to enable jinja by default to allow tool calling and default system prompts. More and more models require this, so I think it's finally time to make it enabled by default.
However, we don't want to enable this for other examples (like
llama-cliorllama-run), because these examples cannot yet handle rolling back tokens. This can happen when the chat template wants to modify pass tokens, for example, one can delete the reasoning content from the formatted chat.This PR also update the auto-generated docs via
llama-gen-docscommand