-
Notifications
You must be signed in to change notification settings - Fork 140
Laravel 12 Support #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 12 Support #470
Conversation
Compatibility with v12 would be great 🚀 |
The development of this sdk is very slow, we can see how many PR's are likely abandoned, don't know where's the maintainer, but their business are still running 🤔 |
OK, let's wait until the end of the week and I'll fork and be able to support the project |
Any news? |
Hello everyone! Thank you for your contributions and feedback. @lee-to – We really appreciate the work you’ve put into this PR. Currently, our automated tests are failing, so could you please take a look and update the branch so that everything passes? Once the tests are green, we’ll be able to move forward with reviewing your changes in detail. Regarding the concerns about maintainership and response times: We understand the frustration when issues and PRs aren’t merged as quickly as you’d like. However, please remember that our team has been focusing on some higher-priority features that needed immediate attention. We value community contributions—and your patience—while we balance these priorities. We’re committed to making this SDK better, and contributions from the community are a big part of that. If you have suggestions or forks you’d like to share, we’re always open to considering them, but let’s keep the tone collaborative. Thank you all for your understanding. We look forward to getting this PR in shape and merged! |
Hello and thank you for your reply! The tests did not pass because you have a non-existent import (Spatie\LaravelRay\RayServiceProvider) in your tests that is not in the dependencies, if you remove it, everything works, I added a fix by excluding it. I also noticed that you do not have a matrix with supported versions of Laravel in ci, at least now I would like to add 12 |
@lee-to I believe the Build and Test is still failing on this PR. Unless and until it is fixed, I can't move ahead. |
@lee-to Check out the latest run. Psalm and CS Fixer is still failing |
These failing tests are due to issues present on the main branch and are not related to @lee-to's changes made in this PR. Fixing them in this PR appears to be beyond the scope of the issue being addressed in these changes, and would not be in keeping with Auth0's General Contribution Guidelines regarding Pull Requests. I have opened another PR (#471) addressing the failing tests and missing dependency. |
Returned RayServiceProvider in TestCase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@lee-to I have approved the changes but I am blocked to merge it. Can you please sign all of your commits in this PR. |
Combined all commits into one and added a signature |
So now that the update is merged, can we get a new release? |
Yeah bumping an official release version would be nice. Pulling the latest version in as And this is on a pretty fresh Laravel app. It is added Auth0 independently and not working exactly off their starting kit. But seems like it needs a release bump with these changes in there since the PR shows it'll bring it inline with these illuminate versions. |
@kishore7snehil It would be cool to make a release with this fix. |
@lee-to The release PR is already up. |
Changes
Illuminate 12
References
Issue #469
Contributor Checklist