Skip to content

Laravel 12 Support #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Laravel 12 Support #470

merged 1 commit into from
Mar 26, 2025

Conversation

lee-to
Copy link
Contributor

@lee-to lee-to commented Mar 5, 2025

Changes

Illuminate 12

References

Issue #469

Contributor Checklist

@lee-to lee-to requested a review from a team as a code owner March 5, 2025 18:37
@ABartelt
Copy link

ABartelt commented Mar 6, 2025

Compatibility with v12 would be great 🚀

@margarizaldi
Copy link

The development of this sdk is very slow, we can see how many PR's are likely abandoned, don't know where's the maintainer, but their business are still running 🤔
That would be great to fork and create such an unofficial update "while waiting" (at least) this PR to be merged... Many (or mostly, or all) of us are running businesses, wasting time is wasting money right?

@lee-to
Copy link
Contributor Author

lee-to commented Mar 14, 2025

The development of this sdk is very slow, we can see how many PR's are likely abandoned, don't know where's the maintainer, but their business are still running 🤔

That would be great to fork and create such an unofficial update "while waiting" (at least) this PR to be merged... Many (or mostly, or all) of us are running businesses, wasting time is wasting money right?

OK, let's wait until the end of the week and I'll fork and be able to support the project

@BrunoWisniewski
Copy link

Any news?

@kishore7snehil
Copy link
Contributor

Hello everyone! Thank you for your contributions and feedback.

@lee-to – We really appreciate the work you’ve put into this PR. Currently, our automated tests are failing, so could you please take a look and update the branch so that everything passes? Once the tests are green, we’ll be able to move forward with reviewing your changes in detail.

Regarding the concerns about maintainership and response times: We understand the frustration when issues and PRs aren’t merged as quickly as you’d like. However, please remember that our team has been focusing on some higher-priority features that needed immediate attention. We value community contributions—and your patience—while we balance these priorities.

We’re committed to making this SDK better, and contributions from the community are a big part of that. If you have suggestions or forks you’d like to share, we’re always open to considering them, but let’s keep the tone collaborative.

Thank you all for your understanding. We look forward to getting this PR in shape and merged!

@lee-to
Copy link
Contributor Author

lee-to commented Mar 17, 2025

Hello everyone! Thank you for your contributions and feedback.

@lee-to – We really appreciate the work you’ve put into this PR. Currently, our automated tests are failing, so could you please take a look and update the branch so that everything passes? Once the tests are green, we’ll be able to move forward with reviewing your changes in detail.

Regarding the concerns about maintainership and response times: We understand the frustration when issues and PRs aren’t merged as quickly as you’d like. However, please remember that our team has been focusing on some higher-priority features that needed immediate attention. We value community contributions—and your patience—while we balance these priorities.

We’re committed to making this SDK better, and contributions from the community are a big part of that. If you have suggestions or forks you’d like to share, we’re always open to considering them, but let’s keep the tone collaborative.

Thank you all for your understanding. We look forward to getting this PR in shape and merged!

Hello and thank you for your reply! The tests did not pass because you have a non-existent import (Spatie\LaravelRay\RayServiceProvider) in your tests that is not in the dependencies, if you remove it, everything works, I added a fix by excluding it. I also noticed that you do not have a matrix with supported versions of Laravel in ci, at least now I would like to add 12

@kishore7snehil
Copy link
Contributor

@lee-to I believe the Build and Test is still failing on this PR. Unless and until it is fixed, I can't move ahead.

@kishore7snehil
Copy link
Contributor

@lee-to Check out the latest run. Psalm and CS Fixer is still failing

@noevidenz noevidenz mentioned this pull request Mar 20, 2025
2 tasks
@noevidenz
Copy link
Contributor

These failing tests are due to issues present on the main branch and are not related to @lee-to's changes made in this PR.

Fixing them in this PR appears to be beyond the scope of the issue being addressed in these changes, and would not be in keeping with Auth0's General Contribution Guidelines regarding Pull Requests.

I have opened another PR (#471) addressing the failing tests and missing dependency.

@lee-to
Copy link
Contributor Author

lee-to commented Mar 20, 2025

These failing tests are due to issues present on the main branch and are not related to @lee-to's changes made in this PR.

Fixing them in this PR appears to be beyond the scope of the issue being addressed in these changes, and would not be in keeping with Auth0's General Contribution Guidelines regarding Pull Requests.

I have opened another PR (#471) addressing the failing tests and missing dependency.

Returned RayServiceProvider in TestCase

Copy link
Contributor

@kishore7snehil kishore7snehil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kishore7snehil
Copy link
Contributor

@lee-to I have approved the changes but I am blocked to merge it. Can you please sign all of your commits in this PR.

@lee-to
Copy link
Contributor Author

lee-to commented Mar 26, 2025

@lee-to I have approved the changes but I am blocked to merge it. Can you please sign all of your commits in this PR.

Combined all commits into one and added a signature

@kishore7snehil kishore7snehil merged commit 57df12e into auth0:main Mar 26, 2025
5 of 6 checks passed
@Neorej
Copy link

Neorej commented Apr 2, 2025

So now that the update is merged, can we get a new release?

@JackMcE
Copy link

JackMcE commented Apr 3, 2025

Yeah bumping an official release version would be nice. Pulling the latest version in as "auth0/login": "^7.15" still causes errors with illuminate/contracts ^11.

And this is on a pretty fresh Laravel app. It is added Auth0 independently and not working exactly off their starting kit.

But seems like it needs a release bump with these changes in there since the PR shows it'll bring it inline with these illuminate versions.

@lee-to
Copy link
Contributor Author

lee-to commented Apr 3, 2025

@kishore7snehil It would be cool to make a release with this fix.

@kishore7snehil kishore7snehil mentioned this pull request Apr 6, 2025
@kishore7snehil
Copy link
Contributor

@lee-to The release PR is already up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants