bugfix: Fix clientAssertionSigningKey
type mismatch
#2243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves a TypeScript error by aligning the
clientAssertionSigningKey
type with thejose
library. This ensures the key is correctly processed for client assertion signing.🔍 RCA
The
clientAssertionSigningKey
property was typed as a genericCryptoKey
, but it was being assigned ajose.CryptoKey
. This created a type conflict becausejose.CryptoKey
is not directly assignable to the Web CryptoCryptoKey
type.📋 Changes
The changes align the type definitions and ensure the key is correctly cast when used.
src/server/auth-client.test.ts
: Updated the test helper'sprivateKey
parameter to usejose.CryptoKey
.src/server/auth-client.ts
: UpdatedclientAssertionSigningKey
to usejose.CryptoKey
and cast it toCryptoKey
when callingoauth.PrivateKeyJwt
.🎯 Testing
Automated:
The existing test suite covers the client assertion signing logic and continues to pass with these type corrections.