Skip to content

Make code-coverage mandatory when running tests #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2018
Merged

Make code-coverage mandatory when running tests #495

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87f9519
Made code-coverage mandatory when running the tests.
JacoKoster Jun 19, 2018
9066652
Missed the trailing-comma...
JacoKoster Jun 19, 2018
d4c46b7
Merge branch 'master' into addition-istanbul-config
JacoKoster Jun 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,24 @@
"version": "8.3.0",
"description": "JSON Web Token implementation (symmetric and asymmetric)",
"main": "index.js",
"nyc": {
"check-coverage": true,
"lines": 95,
"statements": 95,
"functions": 100,
"branches": 95,
"exclude": [
"./test/**"
],
"reporter": [
"json",
"lcov",
"text-summary"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean no HTML reporter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preferably it should be 100% coverage, but as we are missing some tests on exception handling and @MitMaro is in the process of refactoring the tests, i was being liberate ;-)

Lcov includes a html reporter :-)

screen shot 2018-06-25 at 20 54 35

]
},
"scripts": {
"lint": "eslint .",
"test": "npm run lint && nyc --reporter=html --reporter=text mocha && nsp check && cost-of-modules"
"test": "npm run lint && nyc mocha && nsp check && cost-of-modules"
},
"repository": {
"type": "git",
Expand Down