fix(dispatch): #1589 — phantom dispatch (cwd, observability, status filter) by namastex888 · Pull Request #1599 · automagik-dev/genie

namastex888 · 2026-04-30T22:59:39Z

Summary

Closes #1589 — genie work advanced PG state but never spawned a real worker. Three architectural gaps allowed the bug to ship through 4.260430.20–.23:

Spawn cwd silently overridden. dispatch.ts forwarded team but not cwd to handleWorkerSpawn. agents.ts:2393 then clobbered agent.repoPath with teamConfig.worktreePath, so wish dispatches landed in the team's default worktree (e.g. dogfood-session), never the wish worktree.
Readiness probe warned and proceeded. awaitAgentReadiness console.log'd on timeout and returned successfully, masking silent spawn failures.
Wish-status surfaced unrelated team-mates. printWishExecutors listed every team agent with a current executor and only relabeled the task column based on assignment.wishSlug — the dog-fooder's long-running engineer appeared under every wish's "Active Executors", masking phantom dispatches.

Fixes

dispatch.ts — pass cwd: process.cwd() to all 4 handleWorkerSpawn callsites (brainstorm/wish/work/review). Emit wish.dispatch.work audit event before handleWorkerSpawn so dispatch is observable in genie events list even when spawn no-ops or auto-resumes a stale executor.
agents.ts — gate the team-worktree override on !options.cwd so explicit cwd from dispatch is honored. Add AgentReadinessTimeoutError and convert awaitAgentReadiness to throw in strict mode (default). Add tolerateReadinessTimeout?: boolean opt-out to SpawnOptions + SpawnCtx for legacy fire-and-forget callers.
state.ts + task/status.ts — if (assignment?.wishSlug !== slug) continue filter on the executor list so only the wish's actual workers appear under "Active Executors".

Test plan

bun test src/term-commands/dispatch.test.ts — 77 pass (70 existing + 7 new regression-guards), 0 fail.
bun test src/term-commands — 579 pass, 0 fail.
bun run typecheck — clean (after bun install for missing @opentui/keymap).
bun run lint — clean (only pre-existing team-manager.ts:617 and buildSpawnParams complexity warnings, both untouched).
bun run wishes:lint — fix-genie-work-phantom-dispatch wish structurally clean.
bun run lint:emit — pass.
Empirical post-merge: from a felipe-style orchestrator session with GENIE_TEAM=genie, run genie work tui-bottom-bar-opentui from ~/.genie/worktrees/tui-bottom-bar-opentui. Expected: pgrep -af engineer-1 returns a live PID; ls -la /proc/<pid>/cwd shows the wish worktree; genie events list --since 5m shows a wish.dispatch.work event; genie wish status tui-bottom-bar-opentui "Active Executors" shows only the dispatched engineer (no dog-fooder bleed).

Files

src/term-commands/agents.ts        +60 -8   (cwd guard, AgentReadinessTimeoutError, opts/ctx flag)
src/term-commands/dispatch.ts      +31 -0   (cwd forwarding x4 + dispatch.work event)
src/term-commands/dispatch.test.ts +124 -0  (7 regression-guard tests)
src/term-commands/state.ts         +9 -2    (printWishExecutors filter)
src/term-commands/task/status.ts   +8 -2    (printActiveExecutors filter)
.genie/wishes/fix-genie-work-phantom-dispatch/WISH.md (new)

Authority

Investigation: genie work: dispatch sets group in_progress but no worker is spawned and no task message is delivered (4.260430.22) #1589 comment 4356550239 (felipe — surfaces 1–4 with file:line)
Reproduction evidence: genie work: dispatch sets group in_progress but no worker is spawned and no task message is delivered (4.260430.22) #1589 comments 4356510455 (.23 repro), 4356521047 (cross-wish bleed verification)

🤖 Generated with Claude Code

…ilter) `genie work <slug>` advanced PG state to `in_progress` but never spawned a real worker. Three architectural gaps allowed the bug to ship: 1. **Spawn cwd silently overridden.** `dispatch.ts` forwarded `team` but not `cwd` to `handleWorkerSpawn`. `agents.ts:2393` then clobbered `agent.repoPath` with `teamConfig.worktreePath`, so wish dispatches landed in the team's default worktree (e.g. `dogfood-session`) instead of the wish worktree. The agent ran in the wrong repo and never saw the wish files. 2. **Readiness probe warned and proceeded.** `awaitAgentReadiness` `console.log`'d on timeout and returned successfully — making silent spawn failures invisible to dispatch and to operators. 3. **Wish-status surfaced unrelated team-mates.** `printWishExecutors` listed every team agent with a current executor and only relabeled the task column based on `assignment.wishSlug`. The dog-fooder's long-running `engineer` appeared under every wish's "Active Executors", masking phantom dispatches. Fixes: - Add `cwd` forwarding to all 4 `handleWorkerSpawn` callsites in dispatch.ts (brainstorm, wish, work, review). Gate the team-worktree override on `!options.cwd` so explicit cwd from dispatch is honored. - Emit a `wish.dispatch.work` audit event from `runWorkDispatch` BEFORE `handleWorkerSpawn` so dispatch is observable in `genie events list` even when spawn no-ops or auto-resumes a stale executor. - Convert `awaitAgentReadiness` timeout from warn-and-proceed to throwing `AgentReadinessTimeoutError` in strict mode (default). Callers can opt back into warn-and-proceed via `SpawnOptions.tolerateReadinessTimeout: true`. - Filter "Active Executors" in `state.ts:printWishExecutors` and `task/status.ts:printActiveExecutors` to skip executors whose `assignment.wishSlug !== slug` (drop the cross-wish bleed-through). Tests: - 7 new regression-guard tests in `dispatch.test.ts` covering all four cwd callsites, the override gate, the dispatch event ordering, the readiness error class, the SpawnOptions/SpawnCtx flag, and both status-display filters. Total: 77 pass (70 existing + 7 new), 0 fail. - Full `bun test src/term-commands` 579 pass, 0 fail. - `bun run typecheck` clean (only pre-existing TUI keymap errors). - `bun run lint` clean (only pre-existing `team-manager.ts` and `buildSpawnParams` complexity, both untouched). Closes #1589 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

coderabbitai · 2026-04-30T22:59:45Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a5da5df0-8477-4afe-9a64-2cabc8d15d01

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch wish/fix-genie-work-phantom-dispatch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f98bc550fc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-30T23:04:21Z

+  console.error(`  ✗ Agent readiness timeout (${Math.round(result.elapsedMs / 1000)}s) — failing strict mode`);
+  throw new AgentReadinessTimeoutError(role, paneId, result.elapsedMs);


Transition out of spawning before throwing timeout

The new strict timeout path throws AgentReadinessTimeoutError, but this exception is raised before launchTmuxSpawn runs the state transitions that move executor/agent rows out of spawning (see the transition block immediately after the readiness await). In timeout or false-negative cases, handleWorkerSpawn now exits with rows left in spawning, which can mislead status/recovery flows and leave stale in-progress workers. Catch this path and mark executor/agent as a terminal/error state before rethrowing.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-30T23:04:21Z

+      if (assignment?.wishSlug !== slug) continue;
+      const taskLabel = `Group ${assignment.groupNumber ?? '?'}`;


Keep active executors visible when assignment is missing

This filter drops any executor without an active assignment row, but spawn flow does not create assignment records synchronously, so getActiveAssignment(executor.id) can be null even for legitimately running workers. After this change, genie status/genie task status can show no “Active Executors” right after dispatch (and indefinitely where assignments are not written), reducing observability for live work. Preserve visibility for unassigned executors (or fall back to agent metadata) instead of unconditional continue.

Useful? React with 👍 / 👎.

gemini-code-assist

Code Review

This pull request addresses the 'phantom dispatch' issue (#1589) by ensuring wish dispatches use the correct working directory, making agent readiness timeouts fatal by default to surface failures, and filtering the active executors list by wish slug to prevent cross-wish bleed-through. Regression tests have been added to verify these fixes. Feedback was provided to improve the documentation of the CWD resolution logic and to fix a typo in a validation command.

gemini-code-assist · 2026-04-30T23:13:08Z

+
+**Acceptance Criteria:**
+- [ ] `SpawnOptions.cwd` is optional and documented in the type definition.
+- [ ] `agents.ts` cwd resolution prefers `options.cwd` → `agent.entry.dir` → `teamConfig.worktreePath` (in that order).


The description of the cwd resolution order is a bit simplified. The implementation in agents.ts has a more nuanced precedence, including agent.entry.repo and process.cwd() as fallbacks. For improved clarity and to prevent future confusion, consider updating this acceptance criterion to reflect the full resolution logic:

options.cwd

agent.entry.dir

teamConfig.worktreePath

agent.entry.repo

process.cwd()

gemini-code-assist · 2026-04-30T23:13:08Z

+
+**Validation:**
+```bash
+cd /home/genie/workspace/repos/genie && bun test src/term-commands/state.test.ts 2>/dev/null || bun test src/term-commands/state


There appears to be a typo in the validation command. The fallback command bun test src/term-commands/state is likely incorrect as state is not a directory of tests. It should probably be bun test src/term-commands/state.test.ts to match the primary command.

Suggested change

cd /home/genie/workspace/repos/genie && bun test src/term-commands/state.test.ts 2>/dev/null || bun test src/term-commands/state

cd /home/genie/workspace/repos/genie && bun test src/term-commands/state.test.ts 2>/dev/null || bun test src/term-commands/state.test.ts

namastex888 merged commit 1e18356 into dev Apr 30, 2026
16 checks passed

chatgpt-codex-connector Bot reviewed Apr 30, 2026

View reviewed changes

namastex888 mentioned this pull request Apr 30, 2026

genie work: phantom dispatch persists on .24 — engineers still don't spawn despite #1589 PR fix landing #1600

Closed

gemini-code-assist Bot reviewed Apr 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dispatch): #1589 — phantom dispatch (cwd, observability, status filter)#1599

fix(dispatch): #1589 — phantom dispatch (cwd, observability, status filter)#1599
namastex888 merged 1 commit into
devfrom
wish/fix-genie-work-phantom-dispatch

namastex888 commented Apr 30, 2026

Uh oh!

coderabbitai Bot commented Apr 30, 2026

Review skipped

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 30, 2026

Uh oh!

chatgpt-codex-connector Bot Apr 30, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		console.error(` ✗ Agent readiness timeout (${Math.round(result.elapsedMs / 1000)}s) — failing strict mode`);
		throw new AgentReadinessTimeoutError(role, paneId, result.elapsedMs);

		if (assignment?.wishSlug !== slug) continue;
		const taskLabel = `Group ${assignment.groupNumber ?? '?'}`;

	cd /home/genie/workspace/repos/genie && bun test src/term-commands/state.test.ts 2>/dev/null \|\| bun test src/term-commands/state
	cd /home/genie/workspace/repos/genie && bun test src/term-commands/state.test.ts 2>/dev/null \|\| bun test src/term-commands/state.test.ts

Conversation

namastex888 commented Apr 30, 2026

Summary

Fixes

Test plan

Files

Authority

Uh oh!

coderabbitai Bot commented Apr 30, 2026

Review skipped

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant