Reproducibility in cocktail#204
Merged
ArlindKadra merged 2 commits intoMay 11, 2021
Merged
Conversation
ArlindKadra
approved these changes
May 11, 2021
ArlindKadra
left a comment
ArlindKadra
left a comment
There was a problem hiding this comment.
Looks good :), thanks for the PR.
| def __init__(self) -> None: | ||
| super(autoPyTorchSetupComponent, self).__init__() | ||
| def __init__(self, random_state: Optional[np.random.RandomState] = None) -> None: | ||
| super(autoPyTorchSetupComponent, self).__init__(random_state=random_state) |
There was a problem hiding this comment.
ah interesting, did we miss this when we made the changes in development ?
Contributor
Author
There was a problem hiding this comment.
i don't think it affects the code at all.
Contributor
|
Should we pass the see here? |
yes, nice find, without that one, we would be using seed 42 if I am not mistaken |
ravinkohli
force-pushed
the
fix-randomness
branch
from
8c0fbc1 to
c9f75ea
Compare
Contributor
Author
Hey thanks for the comment. I actually didn't rebase before pushing as I had already pushed a PR for this. |
ravinkohli
added a commit
that referenced
this pull request
Dec 8, 2021
* Fix randomness in cocktail ingredients * Fix flake
ravinkohli
added a commit
that referenced
this pull request
Dec 8, 2021
* Fix randomness in cocktail ingredients * Fix flake
ravinkohli
added a commit
that referenced
this pull request
Dec 21, 2021
* Fix randomness in cocktail ingredients * Fix flake
ravinkohli
added a commit
that referenced
this pull request
Jan 24, 2022
* Fix randomness in cocktail ingredients * Fix flake
ravinkohli
added a commit
that referenced
this pull request
Jan 28, 2022
* Fix randomness in cocktail ingredients * Fix flake
ravinkohli
added a commit
that referenced
this pull request
Feb 28, 2022
* Fix randomness in cocktail ingredients * Fix flake
ravinkohli
added a commit
that referenced
this pull request
Feb 28, 2022
* Fix randomness in cocktail ingredients * Fix flake
ravinkohli
added a commit
that referenced
this pull request
Mar 9, 2022
* Fix randomness in cocktail ingredients * Fix flake
ravinkohli
added a commit
to ravinkohli/Auto-PyTorch
that referenced
this pull request
Apr 12, 2022
* Fix randomness in cocktail ingredients * Fix flake
ravinkohli
added a commit
that referenced
this pull request
Jul 26, 2022
* Fix randomness in cocktail ingredients * Fix flake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the reproducibility issues in some of the cocktail ingredients.
Components changed-