-
Notifications
You must be signed in to change notification settings - Fork 299
[ADD] Post-Hoc ensemble fitting #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b4bc6f8
to
50c0189
Compare
Codecov Report
@@ Coverage Diff @@
## development #260 +/- ##
===============================================
+ Coverage 81.76% 81.91% +0.15%
===============================================
Files 151 151
Lines 8641 8677 +36
Branches 1326 1333 +7
===============================================
+ Hits 7065 7108 +43
+ Misses 1104 1096 -8
- Partials 472 473 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I left some comments.
e5a97aa
to
aaf80bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the changes. They look good but I am requesting mainly two things to make it even better:
Add an example where we fit the API sequentially. First search is called with 1 core, then fit the ensemble
Then add some extra checks as mentioned to gain more confidence on the chance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not find large issues except what Francisco already mentioned.
I will wait for another major change.
c455903
to
0881e67
Compare
Adds a fit ensemble method enabling users to post hoc build an ensemble after search is done. This feature allows the user to run a search and sequentially build an ensemble later. This PR also adds tests for the functionality as well as updating
traditional_run_history.json
.