[Fix] long running regression#272
Merged
ravinkohli merged 4 commits intoautoml:developmentfrom Jun 30, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## development #272 +/- ##
===============================================
+ Coverage 81.67% 81.76% +0.08%
===============================================
Files 151 151
Lines 8646 8643 -3
Branches 1328 1327 -1
===============================================
+ Hits 7062 7067 +5
+ Misses 1108 1104 -4
+ Partials 476 472 -4
Continue to review full report at Codecov.
|
Collaborator
nabenabe0928
left a comment
nabenabe0928
left a comment
There was a problem hiding this comment.
Thanks for the PR.
I would like to ask you how this change relates to long running regression?
| metrics = get_metrics(dataset_properties=X['dataset_properties']) | ||
| if 'additional_metrics' in X: | ||
| metrics.extend(get_metrics(dataset_properties=X['dataset_properties'], names=X['additional_metrics'])) | ||
| if 'optimize_metric' in X and 'optimize_metric' not in [m.name for m in metrics]: |
Collaborator
There was a problem hiding this comment.
Can you put a single-line comment for what 'optimize_metric' not in [m.name for m in metrics] this means?
ravinkohli
reviewed
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pytest approximate does not work with compare equal.
Also, simplified the additional_metrics code, which caused problem to the long regression.