[style] Remove prefix typing and adapt to google style doc#307
Merged
ravinkohli merged 3 commits intoautoml:developmentfrom Nov 11, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## development #307 +/- ##
===============================================
+ Coverage 82.09% 82.12% +0.03%
===============================================
Files 151 151
Lines 8651 8650 -1
Branches 1322 1322
===============================================
+ Hits 7102 7104 +2
+ Misses 1084 1082 -2
+ Partials 465 464 -1
Continue to review full report at Codecov.
|
nabenabe0928
requested review from
ArlindKadra,
franchuterivera and
ravinkohli
nabenabe0928
force-pushed
the
302-style-adapt-to-reg-cocktail
branch
2 times, most recently
from
f879bd3 to
05dd311
Compare
ravinkohli
reviewed
Nov 3, 2021
ravinkohli
reviewed
Nov 3, 2021
ravinkohli
reviewed
Nov 3, 2021
autoPyTorch/pipeline/components/setup/network_backbone/utils.py
Outdated
Show resolved
Hide resolved
ravinkohli
suggested changes
Nov 3, 2021
Contributor
ravinkohli
left a comment
ravinkohli
left a comment
There was a problem hiding this comment.
Hey, thanks for this PR. I have left 2 minor comments and 1 major comment. I hope they can be resolved.
nabenabe0928
requested review from
ArlindKadra and
ravinkohli
and removed request for
ArlindKadra,
franchuterivera and
ravinkohli
ravinkohli
reviewed
Nov 5, 2021
autoPyTorch/pipeline/components/setup/network_backbone/utils.py
Outdated
Show resolved
Hide resolved
nabenabe0928
force-pushed
the
302-style-adapt-to-reg-cocktail
branch
from
71e8d27 to
2828fea
Compare
The changes are the following: 1. [google doc style] Arguments --> Args 2. [style] typing.xxx --> xxx 3. [mypy] torch.tensor --> torch.Tensor
nabenabe0928
force-pushed
the
302-style-adapt-to-reg-cocktail
branch
from
3e9c1f7 to
ea3dc91
Compare
ravinkohli
reviewed
Nov 10, 2021
autoPyTorch/pipeline/components/setup/network_backbone/utils.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #302.