[FIX] Additional metrics during training#316
Merged
nabenabe0928 merged 4 commits intoautoml:developmentfrom Nov 12, 2021
Merged
[FIX] Additional metrics during training#316nabenabe0928 merged 4 commits intoautoml:developmentfrom
nabenabe0928 merged 4 commits intoautoml:developmentfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## development #316 +/- ##
===============================================
- Coverage 82.01% 81.78% -0.24%
===============================================
Files 151 152 +1
Lines 8652 8669 +17
Branches 1322 1325 +3
===============================================
- Hits 7096 7090 -6
- Misses 1088 1113 +25
+ Partials 468 466 -2
Continue to review full report at Codecov.
|
ravinkohli
force-pushed
the
add_additional_metrics
branch
from
ed80520 to
7680410
Compare
nabenabe0928
requested changes
Nov 12, 2021
Collaborator
nabenabe0928
left a comment
nabenabe0928
left a comment
There was a problem hiding this comment.
Thanks for the change.
I added two minor suggestions.
| self.fit_dictionary['runtime'] = self.budget | ||
| self.fit_dictionary.pop('epochs', None) | ||
| else: | ||
| raise ValueError(f"Unsupported budget type {self.budget_type} provided") |
Collaborator
There was a problem hiding this comment.
Suggested change
| raise ValueError(f"Unsupported budget type {self.budget_type} provided") | |
| raise ValueError(f"budget type must be `epochs` or `runtime`, but got {self.budget_type}") |
ravinkohli
commented
Nov 12, 2021
Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #101