set fill value to max of full dataset + 1#36
Merged
LMZimmer merged 1 commit intoautoml:masterfrom Mar 23, 2020
jonathanburns:nanmax_X
Merged
set fill value to max of full dataset + 1#36LMZimmer merged 1 commit intoautoml:masterfrom jonathanburns:nanmax_X
LMZimmer merged 1 commit intoautoml:masterfrom
jonathanburns:nanmax_X
Conversation
Contributor
|
Hi there, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I'm somewhat new to this repo 👋 .
It looks like if the global max is in not in the current cross_validation split, using
X[train_indices]would lead to different fill values in different CV splits. My impression is that this is undesired, but correct me if I am wrong.Similarly,
all_nan_columnsshould be the same across all CV splits, I think?