Skip to content

jupyter notebook plots for parameter importance#296

Open
JessicaBorja wants to merge 5 commits intoautoml:developmentfrom
JessicaBorja:master
Open

jupyter notebook plots for parameter importance#296
JessicaBorja wants to merge 5 commits intoautoml:developmentfrom
JessicaBorja:master

Conversation

@JessicaBorja
Copy link

Hi,

The plots in jupyter notebook were not working for some of the parameter importance analysis. I noticed that the get_jupyter() method in some of these files was referencing a different dictionary structure than the current.
I added/modify this method for each analysis type that was having issues, so that it plots the corresponding images using matplotlib in a grid.

In configurator_footprint.py I changed the import so that it stops throwing the future_warning for sklearn.

@mlindauer mlindauer requested a review from shukon February 23, 2021 21:11
@shukon
Copy link
Collaborator

shukon commented Feb 26, 2021

Looks good to me from a quick glance. Since it's only jupyter-methods I'd deem it safe to merge, even though travis blocks it... that's some import-struggle with smac methods, I can fix that mid-march. Only thing, I think we should maybe merge to dev-branch first to not mess up general release order?

Copy link
Collaborator

@shukon shukon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, didn't check if it works, but can mid-March. If you checked that it works, that's good enough for me though. Otherwise, maybe change the branch to development?

@JessicaBorja
Copy link
Author

Looks good, didn't check if it works, but can mid-March. If you checked that it works, that's good enough for me though. Otherwise, maybe change the branch to development?

Hi,
I checked the changes after installing the code as a library and there were some errors which I've now fixed, hence the new commit. Anyway, I will change the branch to development.

@JessicaBorja JessicaBorja changed the base branch from master to development March 1, 2021 11:56
@RaghuSpaceRajan
Copy link

Hi,

is there any update on merging this in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants