Skip to content

Exemplary run scripts fail #1

Description

@janikmu

Hi there,

while doing the review for JOSS (openjournals/joss-reviews#10439) I checked out this template repository and tried to run some of the runscripts. I'm not exactly sure what the expectation management here is, so I will consider that they should run after a fresh clone and make install - otherwise it's something to document.

The two HPO scripts cannot run due to bad paths (mighty_domain_randomization).
The multiple seeds script fails on a missing dependency:

(mighty_project_template) janik@Mac mighty_project_template % ./runscripts/run_multiple_seeds.sh
Traceback (most recent call last):
  File "/Users/janik/source/mighty_project_template/mighty_project/run_mighty.py", line 8, in <module>
    import minigrid # noqa: F401
    ^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named 'minigrid'

I don't think this is a blocking issue for the JOSS review, but since it's linked in PyPi I stumbled over it 🙂

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions