Autonat and Kademlia settings updates. #2242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamil-gadelshin
changed the title
nazar-pc
reviewed
Nov 17, 2023
| @@ -100,6 +100,8 @@ const YAMUX_BUFFER_SIZE: usize = Piece::SIZE + 1024 * 1024; | |||
|
|
|||
| /// Max confidence for autonat protocol. Could affect Kademlia mode change. | |||
| pub(crate) const AUTONAT_MAX_CONFIDENCE: usize = 3; | |||
| /// We set a very long pause before autonat initialization. | |||
| const AUTONAT_SERVER_PROBE_DELAY: Duration = Duration::from_secs(3600 * 24 * 365); | |||
There was a problem hiding this comment.
Here is why: async-rs/futures-timer#68
nazar-pc
approved these changes
Nov 17, 2023
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several problems with autonat and Kademlia:
Identify::Receivedevent because we had two problems with it: 1)deletion was after the addition of the address and thus it could remove all the addresses, 2) removing all the addresses could remove peer from buckets and thus lose it's long-lasting positionautonat-wrapperbehaviour that catches new listen addresses and new external address candidates from swarm. We add only listen addresses comply with ourenable-private-ipssettings and we use only external address candidates that has similar ports as our listening ports.Code contributor checklist: