-
Notifications
You must be signed in to change notification settings - Fork 183
Viosock driver's signature testing #4395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Use signtool.exe to check whether the driver is digital signed ID:4307 Signed-off-by: Leidong Wang <[email protected]>
WalkthroughAdds new with_viosock variant blocks to two test config files: qemu/tests/cfg/virtio_driver_sign_check.cfg and qemu/tests/cfg/win_sigverif.cfg. Both variants add host exclusions (no Host_RHEL.m6, Host_RHEL.m7, Host_RHEL.m8) and version constraints (required_virtio_win_prewhql = [0.1.291, ) and required_virtio_win = [1.9.48.0, )). The virtio_driver_sign_check variant registers the driver as "viosock". The win_sigverif variant sets driver_name="viosock", driver_verifier="VirtioSocket", and device_name="VirtIO Socket Driver". Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Files/areas to check:
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c025648 to
e210645
Compare
Use "sigverif" Utilityto verifying driver safety ID:4309 Signed-off-by: Leidong Wang <[email protected]>
e210645 to
fdccde9
Compare
|
(1/4) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED |
Support check viosock driver in virtio_driver_sign_check and win_sigverif.
ID: 4307, 4309
Summary by CodeRabbit