Skip to content

Conversation

@leidwang
Copy link
Contributor

@leidwang leidwang commented Nov 4, 2025

Support check viosock driver in virtio_driver_sign_check and win_sigverif.

ID: 4307, 4309

Summary by CodeRabbit

  • New Features
    • Added support for the viosock virtio driver in driver signing checks and Windows signature verification tests.
    • Introduced version constraints for virtio-win (pre-WHQL and WHQL ranges) for the new viosock variant.
    • Updated host compatibility to exclude older RHEL host versions for these variants.

Use signtool.exe to check whether the driver is
digital signed

ID:4307

Signed-off-by: Leidong Wang <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Nov 4, 2025

Walkthrough

Adds new with_viosock variant blocks to two test config files: qemu/tests/cfg/virtio_driver_sign_check.cfg and qemu/tests/cfg/win_sigverif.cfg. Both variants add host exclusions (no Host_RHEL.m6, Host_RHEL.m7, Host_RHEL.m8) and version constraints (required_virtio_win_prewhql = [0.1.291, ) and required_virtio_win = [1.9.48.0, )). The virtio_driver_sign_check variant registers the driver as "viosock". The win_sigverif variant sets driver_name="viosock", driver_verifier="VirtioSocket", and device_name="VirtIO Socket Driver".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Homogeneous, small additions to two config files following existing patterns.
  • No code logic changes, only configuration metadata.

Files/areas to check:

  • Consistency of version constraints ([0.1.291, ) and [1.9.48.0, )) across both files.
  • Exact strings: driver_name, driver_verifier, and device_name.
  • Correctness and intended scope of Host_RHEL.m6/m7/m8 exclusions.

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding viosock driver signature testing support to the test configuration files.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e210645 and fdccde9.

📒 Files selected for processing (1)
  • qemu/tests/cfg/win_sigverif.cfg (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • qemu/tests/cfg/win_sigverif.cfg

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@leidwang leidwang force-pushed the driver_check_viosock branch from c025648 to e210645 Compare November 4, 2025 06:35
Use "sigverif" Utilityto verifying driver safety

ID:4309

Signed-off-by: Leidong Wang <[email protected]>
@leidwang leidwang force-pushed the driver_check_viosock branch from e210645 to fdccde9 Compare November 4, 2025 07:41
@leidwang
Copy link
Contributor Author

leidwang commented Nov 4, 2025

(1/4) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED
(1/4) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (956.60 s)
(2/4) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_driver_sign_check.with_viosock.virtio_win_iso_media.q35: STARTED
(2/4) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_driver_sign_check.with_viosock.virtio_win_iso_media.q35: PASS (122.07 s)
(3/4) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.win_sigverif.with_viosock.q35: STARTED
(3/4) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.win_sigverif.with_viosock.q35: PASS (261.84 s)
(4/4) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.win_sigverif.with_viosock.msft_sign_check.q35: STARTED
(4/4) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.win_sigverif.with_viosock.msft_sign_check.q35: PASS (121.73 s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant