-
Notifications
You must be signed in to change notification settings - Fork 183
win_virtio_driver_install_from_update:Support viosock testing #4396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughA new variant configuration block Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
qemu/tests/cfg/win_virtio_driver_install_from_update.cfg(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: CI
qemu/tests/cfg/win_virtio_driver_install_from_update.cfg
[error] 146-146: ParserError: Expected [<class 'main.LIdentifier'>, <class 'main.LDot'>, <class 'main.LColon'>] got <class 'main.LEndL'>: '- with_viosock' (qemu/tests/cfg/win_virtio_driver_install_from_update.cfg:146). Command failed: curl -fsSL https://raw.githubusercontent.com/avocado-framework/avocado-vt/master/virttest/cartesian_config.py | python3 - -f "${CFG_FILE}"
[warning] 552-552: SyntaxWarning: invalid escape sequence '$' in the processed input (stdin).
🔇 Additional comments (1)
qemu/tests/cfg/win_virtio_driver_install_from_update.cfg (1)
146-150: Configuration is correct per VirtIO specification.The device HWIDs are correct: modern PCI device ID 0x1053 is calculated as 0x1040 + VirtIO socket device ID 19, and legacy transitional device ID 0x1012 is defined by QEMU. The configuration follows established patterns and no conflicts exist in the codebase.
Support install virtio socket driver from windows update ID:4660 Signed-off-by: Leidong Wang <[email protected]>
|
(1/1) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.win_virtio_driver_install_from_update.with_viosock.q35: STARTED This failure is due to a product bug, not related to currently automation code. |
Support install virtio socket driver from windows update
ID:4660
Summary by CodeRabbit