Skip to content

Conversation

@leidwang
Copy link
Contributor

@leidwang leidwang commented Nov 4, 2025

Support install virtio socket driver from windows update

ID:4660

Summary by CodeRabbit

  • Tests
    • Added new Windows VirtIO Socket driver test scenarios, expanding driver-installation coverage to include VIRTIO socket paths and improving platform compatibility validation.

@coderabbitai
Copy link

coderabbitai bot commented Nov 4, 2025

Walkthrough

A new variant configuration block with_viosock was added to qemu/tests/cfg/win_virtio_driver_install_from_update.cfg. The variant mirrors existing driver entries and adds a VirtIO Socket Driver section with corresponding HWID entries and device properties, extending the test scenarios to include the VIRTIO socket driver installation path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single configuration file modified: qemu/tests/cfg/win_virtio_driver_install_from_update.cfg
  • Homogeneous addition following existing pattern; no logic or code changes
  • Check: correctness of HWID entries and consistency with other variants

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: adding viosock (virtio socket driver) testing support to the win_virtio_driver_install_from_update configuration file.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b53636f and 8d02e1b.

📒 Files selected for processing (1)
  • qemu/tests/cfg/win_virtio_driver_install_from_update.cfg (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • qemu/tests/cfg/win_virtio_driver_install_from_update.cfg

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a0379c1 and b53636f.

📒 Files selected for processing (1)
  • qemu/tests/cfg/win_virtio_driver_install_from_update.cfg (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: CI
qemu/tests/cfg/win_virtio_driver_install_from_update.cfg

[error] 146-146: ParserError: Expected [<class 'main.LIdentifier'>, <class 'main.LDot'>, <class 'main.LColon'>] got <class 'main.LEndL'>: '- with_viosock' (qemu/tests/cfg/win_virtio_driver_install_from_update.cfg:146). Command failed: curl -fsSL https://raw.githubusercontent.com/avocado-framework/avocado-vt/master/virttest/cartesian_config.py | python3 - -f "${CFG_FILE}"


[warning] 552-552: SyntaxWarning: invalid escape sequence '$' in the processed input (stdin).

🔇 Additional comments (1)
qemu/tests/cfg/win_virtio_driver_install_from_update.cfg (1)

146-150: Configuration is correct per VirtIO specification.

The device HWIDs are correct: modern PCI device ID 0x1053 is calculated as 0x1040 + VirtIO socket device ID 19, and legacy transitional device ID 0x1012 is defined by QEMU. The configuration follows established patterns and no conflicts exist in the codebase.

Support install virtio socket driver from windows update

ID:4660

Signed-off-by: Leidong Wang <[email protected]>
@leidwang
Copy link
Contributor Author

leidwang commented Nov 4, 2025

(1/1) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.win_virtio_driver_install_from_update.with_viosock.q35: STARTED
(1/1) Host_RHEL.m10.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.win_virtio_driver_install_from_update.with_viosock.q35: FAIL: viosock Driver can not be installed correctly from windows update (805.16 s)

This failure is due to a product bug, not related to currently automation code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant