ci(pre-commit-ansible): limit ansible-lint to ansible/#6882
Merged
mitsudome-r merged 1 commit intoautowarefoundation:mainfrom Mar 9, 2026
Merged
ci(pre-commit-ansible): limit ansible-lint to ansible/#6882mitsudome-r merged 1 commit intoautowarefoundation:mainfrom
mitsudome-r merged 1 commit intoautowarefoundation:mainfrom
Conversation
Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
mitsudome-r
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pre-commit-ansiblewas checking YAML files outside theansible/directory.This happened because the
ansible-linthook was not explicitly scoped toansible/.This PR limits the
ansible-linttarget toansible/in.pre-commit-config-ansible.yaml.#6886 intentionally breaks the indentation in docker/docker-compose.yaml to show that pre-commit-ansible incorrectly checks YAML files outside ansible/, so I deleted them.
Since
ansible-lintis now explicitly scoped toansible/, the previousexclude_pathsentries for directories outsideansible/are no longer necessary.How was this PR tested?
pre-commit-ansibleignores non-Ansible YAML file (docker/docker-compose.yaml) after this changeansible/does not failpre-commit-ansible.pre-commit-ansiblestill detects invalid YAML underansible/ansible/still failspre-commit-ansible.