Skip to content

Commit e79f256

Browse files
authored
Merge branch 'main' into feat/adopt-cie-trajectory-follower
2 parents 6bbdffb + 13ff728 commit e79f256

File tree

38 files changed

+366
-102
lines changed

38 files changed

+366
-102
lines changed

.github/workflows/build-and-test-daily.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
uses: ./.github/workflows/build-and-test-reusable.yaml
4949
with:
5050
rosdistro: ${{ matrix.rosdistro }}
51-
container: ${{ matrix.container-base }}${{ matrix.container-suffix }}
51+
container: ${{ matrix.container-base }}
5252
container-suffix: ${{ matrix.container-suffix }}
5353
runner: ${{ matrix.runner }}
5454
build-pre-command: ${{ matrix.build-pre-command }}

.github/workflows/build-and-test.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ jobs:
1515
include:
1616
# ROS distribution specific configurations
1717
- rosdistro: humble
18-
container: ghcr.io/autowarefoundation/autoware:universe-devel-cuda
18+
container: ghcr.io/autowarefoundation/autoware:universe-devel
1919

2020
- rosdistro: jazzy
21-
container: ghcr.io/autowarefoundation/autoware:universe-devel-jazzy-amd64-cuda
21+
container: ghcr.io/autowarefoundation/autoware:universe-devel-jazzy-amd64
2222

2323
uses: ./.github/workflows/build-and-test-reusable.yaml
2424
with:

perception/autoware_detected_object_feature_remover/CMakeLists.txt

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ cmake_minimum_required(VERSION 3.14)
22
project(autoware_detected_object_feature_remover)
33

44
find_package(autoware_cmake REQUIRED)
5+
find_package(autoware_agnocast_wrapper REQUIRED)
56
autoware_package()
67

78
find_package(PCL REQUIRED COMPONENTS common)
@@ -17,16 +18,24 @@ ament_auto_add_library(${PROJECT_NAME} SHARED
1718
src/detected_object_feature_remover_node.cpp
1819
)
1920

21+
target_include_directories(${PROJECT_NAME} PRIVATE
22+
${autoware_agnocast_wrapper_INCLUDE_DIRS}
23+
)
24+
2025
ament_target_dependencies(${PROJECT_NAME}
2126
${DETECTED_OBJECT_FEATURE_REMOVER_DEPENDENCIES}
27+
autoware_agnocast_wrapper
2228
)
2329

24-
rclcpp_components_register_node(${PROJECT_NAME}
30+
autoware_agnocast_wrapper_setup(${PROJECT_NAME})
31+
32+
autoware_agnocast_wrapper_register_node(${PROJECT_NAME}
2533
PLUGIN "autoware::detected_object_feature_remover::DetectedObjectFeatureRemover"
2634
EXECUTABLE detected_object_feature_remover_node
35+
AGNOCAST_EXECUTOR SingleThreadedAgnocastExecutor
2736
)
2837

29-
if(BUILD_TESTING)
38+
if(BUILD_TESTING AND (NOT "$ENV{ENABLE_AGNOCAST}" STREQUAL "1"))
3039
find_package(ament_cmake_gtest REQUIRED)
3140
ament_add_gtest(test_${PROJECT_NAME}
3241
test/test_detected_object_feature_remover_node.cpp

perception/autoware_detected_object_feature_remover/launch/detected_object_feature_remover.launch.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
<launch>
2+
<include file="$(find-pkg-share autoware_agnocast_wrapper)/launch/agnocast_env.launch.xml"/>
3+
24
<arg name="input"/>
35
<arg name="output"/>
46
<arg name="node_name" default="detected_object_feature_remover"/>
57
<arg name="run_convex_hull_conversion" default="false"/>
68

79
<node pkg="autoware_detected_object_feature_remover" exec="detected_object_feature_remover_node" name="$(var node_name)" output="screen">
10+
<env name="LD_PRELOAD" value="$(var ld_preload_value)"/>
811
<remap from="~/input" to="$(var input)"/>
912
<remap from="~/output" to="$(var output)"/>
1013
<param name="run_convex_hull_conversion" value="$(var run_convex_hull_conversion)"/>

perception/autoware_detected_object_feature_remover/package.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
<buildtool_depend>ament_cmake</buildtool_depend>
1414
<buildtool_depend>autoware_cmake</buildtool_depend>
1515

16+
<depend>autoware_agnocast_wrapper</depend>
1617
<depend>autoware_perception_msgs</depend>
1718
<depend>autoware_utils</depend>
1819
<depend>geometry_msgs</depend>

perception/autoware_detected_object_feature_remover/src/detected_object_feature_remover_node.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,21 @@ namespace autoware::detected_object_feature_remover
2323
DetectedObjectFeatureRemover::DetectedObjectFeatureRemover(const rclcpp::NodeOptions & node_options)
2424
: Node("detected_object_feature_remover", node_options)
2525
{
26-
using std::placeholders::_1;
2726
pub_ = this->create_publisher<DetectedObjects>("~/output", rclcpp::QoS(1));
28-
sub_ = this->create_subscription<DetectedObjectsWithFeature>(
29-
"~/input", 1, std::bind(&DetectedObjectFeatureRemover::objectCallback, this, _1));
27+
AUTOWARE_SUBSCRIPTION_OPTIONS options;
28+
sub_ = AUTOWARE_CREATE_SUBSCRIPTION(
29+
DetectedObjectsWithFeature, "~/input", 1,
30+
[this](const AUTOWARE_MESSAGE_CONST_SHARED_PTR(DetectedObjectsWithFeature) & input) {
31+
this->objectCallback(input);
32+
},
33+
options);
3034
convert_params_.run_convex_hull_conversion =
3135
this->declare_parameter<bool>("run_convex_hull_conversion", false);
3236
published_time_publisher_ = std::make_unique<autoware_utils::PublishedTimePublisher>(this);
3337
}
3438

3539
void DetectedObjectFeatureRemover::objectCallback(
36-
const DetectedObjectsWithFeature::ConstSharedPtr input)
40+
const AUTOWARE_MESSAGE_CONST_SHARED_PTR(DetectedObjectsWithFeature) & input)
3741
{
3842
DetectedObjects output;
3943
convert::convertToDetectedObjects(*input, output, convert_params_);

perception/autoware_detected_object_feature_remover/src/detected_object_feature_remover_node.hpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
#include "autoware/detected_object_feature_remover/convert.hpp"
1919

20+
#include <autoware/agnocast_wrapper/autoware_agnocast_wrapper.hpp>
2021
#include <autoware_utils/ros/published_time_publisher.hpp>
2122
#include <rclcpp/rclcpp.hpp>
2223

@@ -36,11 +37,11 @@ class DetectedObjectFeatureRemover : public rclcpp::Node
3637
explicit DetectedObjectFeatureRemover(const rclcpp::NodeOptions & node_options);
3738

3839
private:
39-
rclcpp::Subscription<DetectedObjectsWithFeature>::SharedPtr sub_;
40+
AUTOWARE_SUBSCRIPTION_PTR(DetectedObjectsWithFeature) sub_;
4041
rclcpp::Publisher<DetectedObjects>::SharedPtr pub_;
4142
convert::ConvertParams convert_params_;
4243
std::unique_ptr<autoware_utils::PublishedTimePublisher> published_time_publisher_;
43-
void objectCallback(const DetectedObjectsWithFeature::ConstSharedPtr input);
44+
void objectCallback(const AUTOWARE_MESSAGE_CONST_SHARED_PTR(DetectedObjectsWithFeature) & input);
4445
};
4546

4647
} // namespace autoware::detected_object_feature_remover

perception/autoware_detection_by_tracker/CMakeLists.txt

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ cmake_minimum_required(VERSION 3.14)
22
project(autoware_detection_by_tracker)
33

44
find_package(autoware_cmake REQUIRED)
5+
find_package(autoware_agnocast_wrapper REQUIRED)
56
autoware_package()
67

78
# Ignore -Wnonportable-include-path in Clang for mussp
@@ -28,14 +29,25 @@ ament_auto_add_library(${PROJECT_NAME} SHARED
2829
src/tracker/tracker_handler.cpp
2930
)
3031

32+
target_include_directories(${PROJECT_NAME} PRIVATE
33+
${autoware_agnocast_wrapper_INCLUDE_DIRS}
34+
)
35+
36+
ament_target_dependencies(${PROJECT_NAME}
37+
autoware_agnocast_wrapper
38+
)
39+
3140
target_link_libraries(${PROJECT_NAME}
3241
Eigen3::Eigen
3342
${PCL_LIBRARIES}
3443
)
3544

36-
rclcpp_components_register_node(${PROJECT_NAME}
45+
autoware_agnocast_wrapper_setup(${PROJECT_NAME})
46+
47+
autoware_agnocast_wrapper_register_node(${PROJECT_NAME}
3748
PLUGIN "autoware::detection_by_tracker::DetectionByTracker"
3849
EXECUTABLE detection_by_tracker_node
50+
AGNOCAST_EXECUTOR SingleThreadedAgnocastExecutor
3951
)
4052
ament_auto_package(INSTALL_TO_SHARE
4153
launch

perception/autoware_detection_by_tracker/launch/detection_by_tracker.launch.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<launch>
3+
<include file="$(find-pkg-share autoware_agnocast_wrapper)/launch/agnocast_env.launch.xml"/>
4+
35
<arg name="input/tracked_objects" default="/perception/object_recognition/tracking/objects"/>
46
<arg name="input/initial_objects" default="/perception/object_recognition/detection/clustering/objects_with_feature"/>
57
<arg name="output" default="objects"/>
68
<arg name="detection_by_tracker_param_path" default="$(find-pkg-share autoware_detection_by_tracker)/config/detection_by_tracker.param.yaml"/>
79
<node pkg="autoware_detection_by_tracker" exec="detection_by_tracker_node" name="detection_by_tracker_node" output="screen">
10+
<env name="LD_PRELOAD" value="$(var ld_preload_value)"/>
811
<remap from="~/input/tracked_objects" to="$(var input/tracked_objects)"/>
912
<remap from="~/input/initial_objects" to="$(var input/initial_objects)"/>
1013
<remap from="~/output" to="$(var output)"/>

perception/autoware_detection_by_tracker/package.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
<buildtool_depend>autoware_cmake</buildtool_depend>
1515
<buildtool_depend>eigen3_cmake_module</buildtool_depend>
1616

17+
<depend>autoware_agnocast_wrapper</depend>
1718
<depend>autoware_euclidean_cluster</depend>
1819
<depend>autoware_object_recognition_utils</depend>
1920
<depend>autoware_shape_estimation</depend>

0 commit comments

Comments
 (0)