Settings file support

[hatzel]

Am I correct in assuming that settings files like this: https://github.com/rust-lang-nursery/rls#configuration are not supported in LanguageClient-neovim? If so could you give me a few pointers as to what it would take to implement this.

[DeltaEvo]

LanguageClient-neovim support sending notifications to language server with https://github.com/autozimu/LanguageClient-neovim/blob/master/doc/LanguageClient.txt#L233, so you are wrong 😄

[hatzel]

Technically correct :D but the interesting part would be having a file in the project root that is used for this.
I am not to sure about security implications though.

[autozimu]

Currently the notification is not implemented.

Should be relatively easy to implement though.

• refer to this to create a wrapper to send workspace/didChangeConfiguration notification https://github.com/autozimu/LanguageClient-neovim/blob/master/rplugin/python3/LanguageClient/LanguageClient.py#L474
• call the wrapper after initialize at https://github.com/autozimu/LanguageClient-neovim/blob/master/rplugin/python3/LanguageClient/LanguageClient.py#L372

[DeltaEvo]

I don't think this must be added to LanguageClient-neovim, because not everyone want to send config the same way, if you want to use a settings.json like VSCode you can implement it with vim script like

function! LoadConfig()
        let config = json_decode(system("cat settings.json"))
        call LanguageClient_notify('workspace/didChangeConfiguration', { 'settings': config })
endfunction

augroup JSON_Config
        autocmd!
        autocmd User LanguageClientStarted call LoadConfig()
augroup END

(I don't tested it)

[hatzel]

I would be in favor of having an auto-discovery option in LanguageClient-neovim for this. That way we are doing it like other plugins (YCM for example). This would mean that I build a function to load a specific file and a function to find the project root, those could be enabled via a variable in your vim config.

Seeing that VSCode does it this way I think the option should even be enabled by default but I am not sure if that really is the "sane default" here.

[autozimu]

I'm fine with adding support in this plugin.

We could implement behind a settings, with default to not send settings file.

[juancampa]

@hatzel If I understand correctly this would add support for "workspaces", right?. i.e. when the server start it should scan all the files in the workspace as opposed to just the current file.