[tmpnet] Enable deployment to kube #3615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
tmpnet-kube
branch
5 times, most recently
from
e01ba97 to
ee9fcab
Compare
marun
force-pushed
the
tmpnet-kube
branch
3 times, most recently
from
85bc291 to
513a7c4
Compare
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
maru-ava
force-pushed
the
tmpnet-kube
branch
from
e808653 to
9919ff2
Compare
maru-ava
changed the base branch from
master
to
tmpnet-check-metrics-collection
maru-ava
force-pushed
the
tmpnet-kube
branch
from
9919ff2 to
d81e971
Compare
maru-ava
force-pushed
the
tmpnet-check-metrics-collection
branch
from
049efef to
a713bbc
Compare
maru-ava
force-pushed
the
tmpnet-kube
branch
from
d81e971 to
3126b84
Compare
maru-ava
force-pushed
the
tmpnet-check-metrics-collection
branch
5 times, most recently
from
bcb258c to
6714c80
Compare
maru-ava
force-pushed
the
tmpnet-kube
branch
2 times, most recently
from
2ef53c5 to
85c300b
Compare
maru-ava
reviewed
May 23, 2025
| @@ -46,7 +46,7 @@ func newGinkgoLogger(cfg zapcore.Encoder) logging.Logger { | |||
| return logging.NewLogger( | |||
| "", | |||
| logging.NewWrappedCore( | |||
| logging.Verbo, | |||
| logging.Info, | |||
There was a problem hiding this comment.
Lowering the level here so that the kube runtime logging is suppressed by default (it's more useful for debugging when implementing than useful for diagnosing a test suite).
Elvis339
reviewed
May 26, 2025
RodrigoVillar
approved these changes
May 27, 2025
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: maru <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: maru <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: maru <[email protected]>
StephenButtolph
approved these changes
May 28, 2025
maru-ava
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Chain: tmpnet+kube
This PR chain enables tmpnet to deploy temporary networks to Kubernetes. Early PRs refactor tmpnet to support the addition in #3615 of a new tmpnet node runtime for kube.
Why this should be merged
How this works
How this was tested
Need to be documented in RELEASES.md?
TODO