Use libevm instead of coreth #3918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May or may not conflict with pr 3923 |
Yes it conflicts with 3923. This one addresses comments in that PR. |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project from using coreth packages to libevm packages to prevent side-effect issues in end-to-end tests.
- Replaces coreth/core and coreth/params with libevm/core and libevm/params in multiple files.
- Introduces a new test (TestMustNotImport) to ensure restricted packages (coreth imports) are not accidentally introduced.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/fixture/tmpnet/genesis.go | Replaced coreth imports with libevm, mitigating side-effects. |
| tests/fixture/imports_test.go | Added a test to check that coreth packages are not imported. |
| tests/e2e/c/dynamic_fees.go | Updated import from coreth/params to libevm/params. |
| genesis/genesis_test.go | Updated import from coreth/core to libevm/core. |
Files not reviewed (1)
- go.mod: Language not supported
StephenButtolph
approved these changes
May 11, 2025
StephenButtolph
changed the title
maru-ava
approved these changes
May 12, 2025
samliok
added a commit
that referenced
this pull request
May 13, 2025
Co-authored-by: Stephen Buttolph <[email protected]> ## Why this should be merged ## How this works ## How this was tested ## Need to be documented in RELEASES.md?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Importing
customtypesandparamspkg causes a libevm side-effect which prevents us to use any libevm based (subnet-evm, coreth) VMs to use the e2e tests here. This PR reduces usage of side-effect pkg.How this was tested
TestMustNotImport, intests/fixture/imports_test.go. This test ensures certain packages do not import restricted modules likeplugin/evm/customtypesandparamsto avoid global configuration conflicts.Need to be documented in RELEASES.md?
No