Skip to content

fix: normalize display amount when using markr #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
csabbee wants to merge 3 commits into
base: next-gen/code-freeze-fixes
Choose a base branch
from
Open

fix: normalize display amount when using markr #666

csabbee wants to merge 3 commits into from

Conversation

@csabbee
Copy link
Contributor

@csabbee csabbee commented Dec 30, 2025

Description

JIRA ticket: CP-12981

Changes

  • Creating a helper method to normalize source and destination amount when using markr provider for swap

Testing

  • swap tokens on evm chains, the amounts displayed in the browser notification should match the amount that was put into the form

Screenshots:

Screenshot 2025-12-30 at 16 31 49 Screenshot 2025-12-30 at 16 31 38

Checklist for the author

Tick each of them when done or if not applicable.

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

pixeleate
pixeleate approved these changes Dec 30, 2025
View reviewed changes
Copy link
Collaborator

@pixeleate pixeleate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@csabbee csabbee changed the base branch from main to next-gen/code-freeze-fixes December 30, 2025 16:55
@csabbee
Merge remote-tracking branch 'origin/next-gen/code-freeze-fixes' into…
afd26db 
… fix/wrong-swap-amounts-in-extension-notification-CP-12981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pixeleate pixeleate pixeleate approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@csabbee @pixeleate @meeh0w