fix(core/txpool): demote error log to warn #1034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error log in `legacypool.go` isn't necessary, since even though the behavior is unexpected, it is handled correctly. A discussion on issue #22301 concluded that this should instead be a warning log.
alarso16
force-pushed
the
alarso16/mempool-warning-silence
branch
from
d3eb8fa to
4696eb0
Compare
alarso16
force-pushed
the
alarso16/mempool-warning-silence
branch
from
4696eb0 to
5188843
Compare
StephenButtolph
approved these changes
Jul 7, 2025
alarso16
force-pushed
the
alarso16/mempool-warning-silence
branch
from
5188843 to
9a3c194
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Extraneous error log causing unnecessary pages. Cherry-picks ethereum/go-ethereum#31332
How this works
This error log in
legacypool.goisn't necessary, since even though the behavior is unexpected, it is handled correctly. A discussion on issue ethereum/go-ethereum#22301 concluded that this should instead be a warning log.How this was tested
N/A
Need to be documented?
No
Need to update RELEASES.md?
Yes