chore(core): blockchain.go alignment with geth #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename symbols - Move non-geth code to blockchain_ext.go - Move fields around to be more similar to geth - Add text formatting to make it more similar to geth
- Reduced API surface for BlockChain - Avoid field name conflicts between BlockChain and blockChain - Avoid easy-to-mistake infinite recursive call loops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Upgrading the underlying geth code is troublesome due to diffs in core/blockchain.go between coreth and geth v1.13.14
How this works
How this was tested
Need to be documented?
Need to update RELEASES.md?