Skip to content

Log transaction-chain mismatch #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Log transaction-chain mismatch #941

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2b4962
Log transaction-chain mismatch
yacovm Apr 29, 2025
d0b87b6
Merge branch 'master' into logChainMismatch
yacovm May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/txpool/legacypool/legacypool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,6 +683,9 @@ func (pool *LegacyPool) validateTxBasics(tx *types.Transaction, local bool) erro
opts.MinTip = new(big.Int)
}
if err := txpool.ValidateTransaction(tx, pool.currentHead.Load(), pool.signer, opts); err != nil {
if pool.chainconfig.ChainID.Cmp(tx.ChainId()) != 0 {
log.Trace("Transaction targets wrong chain", "chainID", tx.ChainId(), "expected", pool.chainconfig.ChainID)
}
Comment on lines +686 to +688
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is the right place to put this (I think we are trying to minimize the diff with geth in the core package.. Right? cc: @ceyonur)

If we do go with this, we shouldn't log this for unprotected transactions.

Suggested change
if pool.chainconfig.ChainID.Cmp(tx.ChainId()) != 0 {
log.Trace("Transaction targets wrong chain", "chainID", tx.ChainId(), "expected", pool.chainconfig.ChainID)
}
if tx.Protected() && pool.chainconfig.ChainID.Cmp(tx.ChainId()) != 0 {
log.Trace("Transaction targets wrong chain", "chainID", tx.ChainId(), "expected", pool.chainconfig.ChainID)
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do go with this, we shouldn't log this for unprotected transactions.

why?

return err
}
return nil
Expand Down
Loading