Skip to content

chore(all): use upstream protocol params #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented May 16, 2025

Why this should be merged

Ported from subnet-evm's merged PR ava-labs/subnet-evm#1563

How this works

  • Move coreth specific params from params/protocol_params.go to params/protocol_params_ext.go
  • Use upstream protocol params and delete params/protocol_params.go
  • TestUpstreamParamsValues is a change detector test to detect a geth params change in a future upgrade to make sure we take it into account.

How this was tested

Existing CI passing

Need to be documented?

No

Need to update RELEASES.md?

No

@qdm12 qdm12 marked this pull request as ready for review May 16, 2025 12:40
@qdm12 qdm12 requested a review from a team as a code owner May 16, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant