Skip to content

Unexport transaction visitor #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

In avalanchego, we have started unexporting visitors because people found the usage of a normal function more readable than passing in visitors.

It might be less important here, but as visitors get more complex (including returning additional values other than just errors) this is more scalable.

How this works

Unexports atomic.SemanticVerifier.

How this was tested

CI

Need to be documented?

No

Need to update RELEASES.md?

No

@StephenButtolph StephenButtolph requested a review from a team as a code owner May 27, 2025 15:26
@StephenButtolph
Copy link
Contributor Author

🤔

@StephenButtolph
Copy link
Contributor Author

No clue why things are failing, but will wait to address this

@StephenButtolph StephenButtolph marked this pull request as draft May 27, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant