ValidatorSetRegistry stubs #1149
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batconjurer
requested review from
geoff-vball,
iansuvak,
mdelle1,
michaelkaplan13 and
ylg-avalabs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
batconjurer
force-pushed
the
bat/validator-set-registry-stubs
branch
from
a5ee2c6 to
06a8da9
Compare
batconjurer
force-pushed
the
bat/validator-set-registry-stubs
branch
from
06a8da9 to
3d08aae
Compare
geoff-vball
reviewed
Jan 7, 2026
Contributor
geoff-vball
left a comment
geoff-vball
left a comment
There was a problem hiding this comment.
One questions otherwise LGTM
| uint32 public immutable avalancheNetworkID; | ||
|
|
||
| constructor( | ||
| uint32 avalancheNetworkID_ |
Contributor
There was a problem hiding this comment.
Sorry if I missed the coversation around this. Is this needed? Is there a potential for collisions between blockchainID between fuji and mainnet? Or is it that we're going to bootstrap with the p-chain validator set, which is unique per network?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This adds the ethereum sub-folder in the contracts. There is a basic unit test to make sure the update scripts and CI jobs works correctly. Built atop #1146
How this works
How this was tested
How is this documented