forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 3
test: branch properties of main
and release/*
#145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6102bbc
to
9857259
Compare
a6f889f
to
ef5a16e
Compare
darioush
approved these changes
Mar 17, 2025
ARR4N
added a commit
that referenced
this pull request
Mar 17, 2025
## Why this should be merged The CI job in #145 requires a local (to the runner) `main` branch and since `actions/checkout` doesn't check it out, the workflow creates the branch off `origin/main`. However, after merge of a PR to `main`, the workflow is run on `main` itself and that step [fails because the branch already exists](https://github.com/ava-labs/libevm/actions/runs/13908218530/job/38916101218). ## How this works Only call `git branch main origin/main` if `main` doesn't exist. ## How this was tested We'll see once it's merged 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Safer release process by enforcing invariants of
release/*
branches as automated in #137 to fulfil #25.How this works
New test for
go_tooling
CI job.If the PR target branch is
main
then only theparams.ReleaseType
is checked. If the target is neithermain
nor a release branch then the test is skipped. The checks performed onrelease/*
branches are described in the test.How this was tested
Locally against a dummy release branch with deliberate problems created by (a) including this PR's changes in the final commit and (b) not updating the libevm version.