refactor(params): make LibEVMVersion a constant
#162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
approved these changes
Mar 13, 2025
qdm12
added a commit
that referenced
this pull request
Mar 27, 2025
#163 was removed by mistake in #162 so this re-adds it Co-authored-by: Arran Schlosberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This will be merged into
mainonce the current target branch has been merged.Why this should be merged
My original implementation was back to front and it's been bugging me.
How this works
Originally
params.LibEVMVersionwas avar(because it needed to be computed) and the test used aconst. This change simply inverts the two and moves some code around without any change in logic.I bumped the minor version to 2 (a no-op when not on a release branch) to bring it in line with the latest release candidate and to avoid forgetting to do so when performing an actual release.
How this was tested
Unit test of version-string constant.