crypto/secp256k1: update libsecp256k1 (#31242) #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
force-pushed
the
arr4n/cherry-pick-5606cbc710ffcf327740e4db54776eb8a3c1a2fc
branch
2 times, most recently
from
f8ead0f to
9146c25
Compare
ARR4N
force-pushed
the
arr4n/cherry-pick-5606cbc710ffcf327740e4db54776eb8a3c1a2fc
branch
from
9146c25 to
c3a3a9e
Compare
Updates the libsecp256k1 dependency to commit: c0d9480fbbf8eccbd4be23ed27f6f2af6f3b211e PR: ``` BenchmarkSign-24 57756 21214 ns/op 164 B/op 3 allocs/op BenchmarkRecover-24 37156 33044 ns/op 80 B/op 1 allocs/op BenchmarkEcrecoverSignature-24 36889 32935 ns/op 80 B/op 1 allocs/op BenchmarkVerifySignature-24 41163 29207 ns/op 0 B/op 0 allocs/op BenchmarkDecompressPubkey-24 318624 4062 ns/op 304 B/op 6 allocs/op ``` Master: ``` BenchmarkSign-24 34509 35330 ns/op 164 B/op 3 allocs/op BenchmarkRecover-24 25418 47725 ns/op 80 B/op 1 allocs/op BenchmarkEcrecoverSignature-24 25735 47591 ns/op 80 B/op 1 allocs/op BenchmarkVerifySignature-24 29108 41097 ns/op 0 B/op 0 allocs/op BenchmarkDecompressPubkey-24 294747 4143 ns/op 304 B/op 6 allocs/op ``` Performance seems to be improved significantly: ``` Sign-24 34.86µ ± 3% 21.66µ ± 2% -37.86% (p=0.000 n=10) Recover-24 46.14µ ± 3% 33.24µ ± 2% -27.95% (p=0.000 n=10) ```
ARR4N
force-pushed
the
arr4n/cherry-pick-5606cbc710ffcf327740e4db54776eb8a3c1a2fc
branch
from
c3a3a9e to
8ae4631
Compare
ARR4N
added
the
Status: 🔴 DO NOT MERGE
ceyonur
reviewed
Jun 25, 2025
ceyonur
approved these changes
Jun 25, 2025
ARR4N
deleted the
arr4n/cherry-pick-5606cbc710ffcf327740e4db54776eb8a3c1a2fc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
DO NOT squash merge. I will fast-forward merge into
main.Why this should be merged
Cherry-picks ethereum#31242
How this works
Tracked in #128 to be reverted when included by an upgrade (avoids merge conflicts).
The only merge conflict in the pick was due to a comment being updated to fix a typo.
How this was tested
Existing tests.