Skip to content
This repository was archived by the owner on May 25, 2019. It is now read-only.

Move back into AVA proper #11

Closed
novemberborn opened this issue Jan 17, 2017 · 4 comments
Closed

Move back into AVA proper #11

novemberborn opened this issue Jan 17, 2017 · 4 comments

Comments

@novemberborn
Copy link
Member

avajs/ava#925 mentions the code was extracted to "allow other tools (i.e. atom-ava, linter, etc) to have access to the file selection logic."

I don't see it in atom-ava's dependencies though.

Given the tight coupling I think it's easier if we can maintain this in AVA itself. We'll have to use TAP again for tests, so that sucks, but thinking about compatibility with current AVA releases sucks more IMHO.

@avajs/core?

@sotojuan
Copy link
Contributor

sotojuan commented Jan 17, 2017

I think if no one has really found a use for it outside of AVA it's safe to put it back, but we should make sure no projects actually use it (or at least no "blessed" AVA-related projects use it).

@sindresorhus
Copy link
Member

I agree. In hindsight, I think we should have only done it out of actual need, not imaginary future need.

Doesn't look like anyone is using it anyways: https://www.npmjs.com/browse/depended/ava-files

@novemberborn
Copy link
Member Author

Cool, I'll raise a ticket with AVA itself.

@novemberborn novemberborn changed the title Move back into AVA proper? Move back into AVA proper Jan 17, 2017
@sindresorhus
Copy link
Member

Fixed by avajs/ava#1196

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants